From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice when ls-lisp is loaded. Date: Wed, 06 Dec 2023 16:32:51 -0500 Message-ID: References: <170177277759.6083.12155719482709043212@vcs2.savannah.gnu.org> <20231205103937.E1D65C405A8@vcs2.savannah.gnu.org> <83plzj4jfk.fsf@gnu.org> <8334wf45v3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2619"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org, luangruo@yahoo.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 06 22:34:27 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAzXG-0000UY-Ci for ged-emacs-devel@m.gmane-mx.org; Wed, 06 Dec 2023 22:34:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rAzWM-0006D6-LH; Wed, 06 Dec 2023 16:33:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAzWL-0006Cw-1Z for emacs-devel@gnu.org; Wed, 06 Dec 2023 16:33:29 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rAzWH-0000MA-If; Wed, 06 Dec 2023 16:33:27 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 18343100218; Wed, 6 Dec 2023 16:33:23 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1701898402; bh=0ZLbSkumYILMrCvXx6AmI2sJ/l1fSPmYGpK0iWydgos=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IqXi0PISudja7lu/OUCvQFPaRjtx8Glh2v0lY04IuM9MMkdA43aKr4YYeGQ5vi8QI m/xsft+FvnYayX3asG2aKWI7T9CpFzrq3jFtANhZTRbyzDpFxCWyPZZJ/yJ1lf9Kvy UtfgsI6nPAsll+qQrkRdVosAq8oF8z862gcM3RsUZgsJIZih4pqc8EAyjCq0vlSJV8 e78keF05wqvwTNSyzPCdt/nd1Cir/s0gjfR/olhyUg6I8y5jyf1wbjx48691McIdbw iSRTcMBAZp8iG4fJcrtYDzd+tA8/dkr6TgimX48UgRdxn83CsZbyzYcwIcAY8LvaQy 3IaYMfqs5haVQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 74718100189; Wed, 6 Dec 2023 16:33:22 -0500 (EST) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 66A191202AA; Wed, 6 Dec 2023 16:33:22 -0500 (EST) In-Reply-To: <8334wf45v3.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 06 Dec 2023 19:07:28 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313572 Archived-At: > If that can be done safely and cleanly, yes. I'll see what I can come up with. > But then I wonder why we decided to use advice all those years ago... Originally, the ls-lisp code did a flat-out override of `insert-directory`, so using an advice was cleaner than what we had before. But I guess I didn't realize back then that `ls-lisp.el` is preloaded in W32 builds (and also: we still used advice in a few other preloaded packages, such as uniquify). Now that it's the last preloaded use of advice, ... Stefan