From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66732: tree-sitter fontification doesn't update multi-line syntax reliably Date: Mon, 11 Dec 2023 09:35:17 -0500 Message-ID: References: <878r7s5cdf.fsf@honnef.co> <83fs1tbou1.fsf@gnu.org> <835y1zo3rw.fsf@gnu.org> <2ce274aa-6d01-4d0a-b10c-07f821343fed@gmail.com> <83o7exueow.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21260"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: dmitry@gutov.dev, Yuan Fu , 66732@debbugs.gnu.org, dominik@honnef.co To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 11 15:36:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rChOL-0005EO-BC for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Dec 2023 15:36:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rChNu-0005xv-D0; Mon, 11 Dec 2023 09:35:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rChNs-0005wI-FC for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 09:35:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rChNr-0006P7-MD for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 09:35:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rChO6-0004QF-4Y for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 09:36:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2023 14:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66732 X-GNU-PR-Package: emacs Original-Received: via spool by 66732-submit@debbugs.gnu.org id=B66732.170230534316971 (code B ref 66732); Mon, 11 Dec 2023 14:36:02 +0000 Original-Received: (at 66732) by debbugs.gnu.org; 11 Dec 2023 14:35:43 +0000 Original-Received: from localhost ([127.0.0.1]:52940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rChNm-0004Pf-DH for submit@debbugs.gnu.org; Mon, 11 Dec 2023 09:35:42 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:49978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rChNj-0004PQ-Ee for 66732@debbugs.gnu.org; Mon, 11 Dec 2023 09:35:41 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 463774441E2; Mon, 11 Dec 2023 09:35:19 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1702305318; bh=KfUWk5K6/E3+j5Jf2GKos7ALgyVKO2Uc4u++nGCGyDE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=deDkk7EaRBdo418De/zSKJgAkR4RW17pywLec3vcX5gY+Xu1anTwbFZ2kpP0i8N8q XnJDq8xItiw3JPV2+Fw2e7hvOL4cyEDG/xptfILZsHKZKAz6NQxlcoXdWm/O9eqA4x WNk0KMh/1FRdx/SkST1cO9aER5i9TSARX01wcsrtYaB4hFi/dYBi7fq3nnjbzuHqXw 8tmvT0iupm4VQEQ7tCF4F5bUNvJzMV0SNBc0wyn7/rGTmTg0crrwyECIQA7VcR0OW6 iExtgxy0uC0nyBvLZcy7mAq+XTlxTHyFS1PSokFLI9t4KZrW2xP+vVC0CFnVgOFZmh QOr7nag41jNiQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1C7CF4441D7; Mon, 11 Dec 2023 09:35:18 -0500 (EST) Original-Received: from pastel (unknown [45.72.203.88]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DDD3B1206C1; Mon, 11 Dec 2023 09:35:17 -0500 (EST) In-Reply-To: <83o7exueow.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 11 Dec 2023 14:05:51 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275984 Archived-At: >> [1] The chain of events if roughly: user types the last "/" -> redisplay >> -> fontify that character -> access parser -> parser reparses -> calls >> notifier. > > The way to mark region of text as not fontified is to set its > 'fontified' property nil. Indeed, but if you do it from within jit-lock it will not work as expected because jit-lock will mark the chunk just processed with `fontified` == t. > Instead of a timer, did you try to use pre-redisplay-function? Anything that runs "later" (i.e. after we exit `jit-lock-fontify-now`) will work, but `pre-redisplay-function` means the display will only be updated at the next redisplay, whereas with a timer we also force a redisplay, thus shortening the time during which we display an incompletely fontified chunk. Jit-lock itself uses a similar timer for similar purposes. We could make it slightly cheaper by exporting the `pending_funcalls` to ELisp and then using it instead of a 0s timer. Stefan