From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68213: 30.0.50; completion-preview-tests failure in --without-x build Date: Mon, 08 Jan 2024 20:01:04 -0500 Message-ID: References: <87ttnvr7x7.fsf@pub.pink> <83plyjzmlv.fsf@gnu.org> <87bka3r4sg.fsf@pub.pink> <83plyixr73.fsf@gnu.org> <87v884619q.fsf@yahoo.com> <87frz85oyx.fsf@yahoo.com> <838r50q9d3.fsf@gnu.org> <877ckj6h5q.fsf@yahoo.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1209"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , jm@pub.pink, me@eshelyaron.com, 68213@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 02:02:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rN0Vc-000Ae5-31 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 02:02:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rN0VC-00008q-GE; Mon, 08 Jan 2024 20:01:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rN0V9-00008P-RJ for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 20:01:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rN0V9-0006P0-IU for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 20:01:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rN0VF-0001Y1-O3 for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 20:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 01:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68213 X-GNU-PR-Package: emacs Original-Received: via spool by 68213-submit@debbugs.gnu.org id=B68213.17047620815093 (code B ref 68213); Tue, 09 Jan 2024 01:02:01 +0000 Original-Received: (at 68213) by debbugs.gnu.org; 9 Jan 2024 01:01:21 +0000 Original-Received: from localhost ([127.0.0.1]:37921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN0Ub-0001Ju-4p for submit@debbugs.gnu.org; Mon, 08 Jan 2024 20:01:21 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:8500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rN0UZ-0001Cn-3s for 68213@debbugs.gnu.org; Mon, 08 Jan 2024 20:01:20 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1350A10009F; Mon, 8 Jan 2024 20:01:07 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1704762065; bh=W67VrMU6OjVP5YNO6C712eUo6HQHC8oUC4EGIo89ygI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Kw4UiLrjpPkJ8C18jNp93Hu4kYFMc73/ZgIvmnHYr0uBqe+J5HnEpYvcQBSqOMFd2 jF8CIv+tkN2Y5gtc6CAIPERVLN5uyv1SJfYqpBCA7PjQcRdApop35RxY29cJASZRFv tWXPLod/J4ZlmXRBrr3G+jTc6k+abWUPIniywVbK8Gzm9Dg1twryICIewtU+IcO5QG ifr+5X3+2FAvuwtO3HbTNyIYRu/k4R8Rn3HGhjVQuBvtLo9HBdHLsSH0nAz0WVaw8H Ny3+ce2FXKukpUQ38UaFBYOBs2kafHAy3Kwqs+D21KEiAqJwoGENouNlvxMzvNDUkf 26KQfMVxI7YNw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E106F10004C; Mon, 8 Jan 2024 20:01:05 -0500 (EST) Original-Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 70F78120472; Mon, 8 Jan 2024 20:01:05 -0500 (EST) In-Reply-To: <877ckj6h5q.fsf@yahoo.com> (Po Lu's message of "Mon, 08 Jan 2024 22:20:17 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277590 Archived-At: >> There's one dog we cannot let lie: the one that fails the test in >> completion-preview-tests to fail to compile -- this is what started >> this bug report, and I would like to solve that problem. > > From a cursory reading of this bug report, I gather that m-w-*-event and > m-w-*-alternate-event are at times defined to identical values, which > causes defvar-keymap to signal? In that situation the correct course of > action is using [remap ...] to bind the mwheel commands to whatever > completion-preview needs it set to, right? I considered doing that, but it's not great: - The same command is used for up and down, so we'd have to change the completion-preview code to have a new command that looks at the invoking event to decide whether to scroll up or down. - The same command is also used for left/right, which we currently don't override in completion-preview, but which a `remap` would also affect. - I'm not sure it's quite the semantics we want (I don't think we want these completion-preview bindings to depend on `mouse-wheel-scroll-amount`). None of those problems are deal breaking, of course, but overall it's not a much better option. And I suspect that once we sort out the m-w-*-event problems, fixing the completion-preview problems will be even easier. Stefan