From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70077: An easier way to track buffer changes Date: Mon, 08 Apr 2024 16:57:11 -0400 Message-ID: References: <86frvy51af.fsf@gnu.org> <86msq3yhot.fsf@gnu.org> <86il0rya4m.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40536"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: acm@muc.de, yantar92@posteo.net, 70077@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 08 22:58:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rtw4E-000AHl-39 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Apr 2024 22:58:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtw3y-0007Ol-Uy; Mon, 08 Apr 2024 16:57:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtw3x-0007Nm-1w for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 16:57:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtw3w-0000zO-Pd for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 16:57:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rtw43-0002tF-UZ for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 16:58:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Apr 2024 20:58:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70077 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70077-submit@debbugs.gnu.org id=B70077.171260986611016 (code B ref 70077); Mon, 08 Apr 2024 20:58:03 +0000 Original-Received: (at 70077) by debbugs.gnu.org; 8 Apr 2024 20:57:46 +0000 Original-Received: from localhost ([127.0.0.1]:47792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtw3j-0002rE-QK for submit@debbugs.gnu.org; Mon, 08 Apr 2024 16:57:46 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtw3T-0002pl-Ku for 70077@debbugs.gnu.org; Mon, 08 Apr 2024 16:57:42 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5341C441C54; Mon, 8 Apr 2024 16:57:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1712609833; bh=SEMtbhWii2mjvSKh0w5Kj+9mZeud33f6DM8yMXHbscE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=Ha6W90gS/bChxi+sEeVO8RFJEnLCwNAItSHzTQ/dScW5HPy90vn8KnWUhrEOFfBtz dsYk74HDUHiKUl2PXa1p+/GfEbGJ+HM2Uvs36SU8CyUXIIIR53+v1Y/Zl15MgwrQ/Q wVd2amhPz10ymY5CLTP113ZDwjT9S8YFOJz9i6LyjLxA092fFZOuau9N5Bp3SUq7D7 WV6NjQeAfiG65AD3Ji+bBmtmxGO/mWn4Cw0OjbJWb+U41Yx/iuPR1oeVudzOf5SwWq LOWwlRiyEUn9X5Q+dQG5cG5W5ekeI0MwM9v1fiGJsp5l+87G2nQQ9H5HcbID+df9GG i3a951jdBq9Tg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id ECF5E441C2A; Mon, 8 Apr 2024 16:57:12 -0400 (EDT) Original-Received: from pastel (unknown [45.72.201.215]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BC7B2120185; Mon, 8 Apr 2024 16:57:12 -0400 (EDT) In-Reply-To: <86il0rya4m.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 08 Apr 2024 21:36:41 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282955 Archived-At: > If this indicates that the slots are of built-in-class type, why do we > show the cryptic t there? No, what it's saying is that these slots can contain values of any type (since any type is a subtype of t). This `Type` information is a way to document what kind of values can be found in those slots. Very often we don't bother specifying it, in which case `t` is used as a default. >> >> >> +By default SIGNAL is called as soon as convenient after a change, which is >> >> > ^^^^^^^^^^^^^^^^^^^^^ >> >> > "as soon as it's convenient", I presume? >> >> Other than the extra " it's", what is the difference? >> > Nothing. I indeed thing "it's" is missing there. >> My local native-English representative says that "both work fine" >> (somewhat dismissively, I must add). > In that case I'll yield, but do note that it got me stumbled. Wow. To me this is just as natural as "as soon as possible", tho used admittedly less frequently. >> > In general, when I want to create a clean slate, I don't care too much >> > about the dirt I remove. Why is it important to signal errors because >> > a state I am dumping had some errors? >> I don't understand why you think it will signal an error? > Doesn't cl-assert signal an error if the condition is false? Yes. What makes you think it will be false? >> More to the point, it should signal an error only if I made a mistake in >> `track-changes.el` or if you messed with the internals. > I have the latter possibility in mind, yes. Why catch me doing that > when I'm cleaning up my mess, _after_ all the damage, such as it is, > was already done? But `track-changes--clean-state` is not a function to "clean up the mess" any more than, say, `track-changes-fetch` or `track-changes--before`. >> >> >> +;;;; Extra candidates for the API. >> >> >> +;; This could be a good alternative to using a temp-buffer like I used in >> >> > ^^^^^^ >> >> > "I"? >> >> Yes, that refers to the code I wrote. >> > We don't usually leave such style in long-term comments and >> > documentation. >> `grep " I " lisp/**/*.el` suggests otherwise. > "A journey of a thousand miles begins with one first step." I disagree with the goal, tho. If you want, I can add something like "--Stef" at the end to clarify who is this "I", tho nowadays I tend to rely on `C-x v h` to find that kind of information. The text there is just recording my thoughts about this part of the design of the API. Stefan