From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69941: 30.0.50; Faulty fontification of radio button widgets Date: Thu, 09 May 2024 10:15:29 -0400 Message-ID: References: <87h6gynx49.fsf@rub.de> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17444"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69941@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 09 16:17:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s54a4-0004Gc-Vm for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 May 2024 16:17:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s54Zb-0004sw-JL; Thu, 09 May 2024 10:16:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s54ZZ-0004sB-MW for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 10:16:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s54ZZ-0008Mr-Dc for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 10:16:37 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s54Zy-0003P5-D1 for bug-gnu-emacs@gnu.org; Thu, 09 May 2024 10:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 May 2024 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69941 X-GNU-PR-Package: emacs Original-Received: via spool by 69941-submit@debbugs.gnu.org id=B69941.171526416813005 (code B ref 69941); Thu, 09 May 2024 14:17:02 +0000 Original-Received: (at 69941) by debbugs.gnu.org; 9 May 2024 14:16:08 +0000 Original-Received: from localhost ([127.0.0.1]:55521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s54Z5-0003Nh-Nl for submit@debbugs.gnu.org; Thu, 09 May 2024 10:16:08 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s54Z1-0003NA-37 for 69941@debbugs.gnu.org; Thu, 09 May 2024 10:16:06 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2FC58100061; Thu, 9 May 2024 10:15:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1715264130; bh=teBw9Nff12NRjd1WqE7bOqaZPXFD3kgQI0DBjEwLE2s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=gLbyBGDANenePv9EhHh0+fbRWS1D4IiNIjsFJkUlNYWUKv2X3PHPTad5GI8NHedZt M4Pg/au2GhqpwC40GMRU2fHoRdGbHzDlgAd6QB1/mlikV46pSgi+9sckFesw2L3f5p fS1hGutRDt3yz8pgNgxOwyuH1/DJeoOubBik34ukiQVCH7xH8QOSo6xsGlUNvsx0Pm lamVnypgDaI5KzSD+8KXXc/urv5L4G+3R0fFnSZTrrLpQjXtag/FKIZWpEriwfX9Y3 h37dYcGJvB7N41o0e2x5K2L5jJuGCQwTsulbP7YJtvESIJH2ArPM4c9EDfTb3SCneL vZY+v6KXbSEeA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0CDA7100035; Thu, 9 May 2024 10:15:30 -0400 (EDT) Original-Received: from pastel (unknown [45.72.201.215]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DD92D120352; Thu, 9 May 2024 10:15:29 -0400 (EDT) In-Reply-To: <87h6gynx49.fsf@rub.de> (Stephen Berman's message of "Fri, 22 Mar 2024 15:45:42 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284759 Archived-At: > I investigated the history of this code, and while the value t for the > marker insertion type was used in the initial commit, it was changed to > nil in commit e0f956935, with the message "Insert new text at the :from > marker _after_ the marker, not before it." But 18 days later it was > changed back to t in commit 3bff434b8, that also added "Document need to > put some text before the %v escape in :format string" of editable-field > widgets. (I looked at the bug-gnu-emacs and emacs-devel mailing list > archives but found nothing relevant at the time just prior to these > commits.) I'm really not familiar with the widget code, but looking around that code I see that we have (set-marker-insertion-type BLAfromBLA t) (set-marker-insertion-type BLAtoBLA nil) at various places, and I think that makes a lot of sense when you consider that we don't want text inserted right before or right after the widget to suddenly become part of the widget. But OTOH while "printing" the widget itself, we'd want the exact opposite (i.e. nil for from and t for to). Could it be that part of the problem is that the insertion of a radio-button widget into a radio-button-choice widget is done "too late", i.e. after the radio-button-choice widget has been printed? Stefan