From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70927: Acknowledgement (30.0.50; track-changes assertion when shutting down eglot) Date: Wed, 15 May 2024 18:09:37 -0400 Message-ID: References: <871q65xsi6.fsf@stebalien.com> <87y18dwdri.fsf@stebalien.com> <87frui6bpg.fsf@stebalien.com> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37988"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 70927-done@debbugs.gnu.org To: Steven Allen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 16 00:10:49 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s7Mpj-0009dQ-LL for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 May 2024 00:10:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7Mp1-0008JQ-Fq; Wed, 15 May 2024 18:10:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7Moz-0008Iz-88 for bug-gnu-emacs@gnu.org; Wed, 15 May 2024 18:10:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7Moy-0001E6-Vj for bug-gnu-emacs@gnu.org; Wed, 15 May 2024 18:10:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s7Mp0-0008VO-JL for bug-gnu-emacs@gnu.org; Wed, 15 May 2024 18:10:02 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 May 2024 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 70927 X-GNU-PR-Package: emacs Mail-Followup-To: 70927@debbugs.gnu.org, monnier@iro.umontreal.ca, steven@stebalien.com Original-Received: via spool by 70927-done@debbugs.gnu.org id=D70927.171581098932675 (code D ref 70927); Wed, 15 May 2024 22:10:02 +0000 Original-Received: (at 70927-done) by debbugs.gnu.org; 15 May 2024 22:09:49 +0000 Original-Received: from localhost ([127.0.0.1]:44732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7Mom-0008Ux-KX for submit@debbugs.gnu.org; Wed, 15 May 2024 18:09:48 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:2318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7Mok-0008Ul-F7 for 70927-done@debbugs.gnu.org; Wed, 15 May 2024 18:09:47 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A374280AD4; Wed, 15 May 2024 18:09:38 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1715810977; bh=quA0vzZ6+hd4mxPhutOZ3zFN9ehDz7qZVs8vn2e2DTE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZFcRPE57XAypX0kD6Q5GuKr8+LF8fayNzn7VWUeHQe51B38c5PWdNstz7KbXTd724 FSu7OkCvgyVxM5FfRaxhd7LN9BZ8B8F0gv9e9EkmYk4oIwKNrZFNthgEUNAO9jzxGY jzNXUGemOoD7dS9ATraUGIDTzQBVHedw3rmgYiPUDgaxoCTlkf8r8sLrWpdVrpnU0I tIAH0o08iDOW0Ek2PeO/N+QwS8N6hINmDK7RPBZ+3QUocldfUoDx41G74RrC5e08/d w2gijAvZ+8tWtvHHoB1QcjebswAlrEF4F+cKpzQnUdNnPdnUQTQnu34xmqwAX74RHk FkPUWqvncM57Q== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9DBE8805C1; Wed, 15 May 2024 18:09:37 -0400 (EDT) Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8D627120422; Wed, 15 May 2024 18:09:37 -0400 (EDT) In-Reply-To: <87frui6bpg.fsf@stebalien.com> (Steven Allen's message of "Wed, 15 May 2024 13:51:07 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285125 Archived-At: >> Indeed. I pushed the patch below to `master` instead which should also >> fix the problem. Please confirm that it fixes it for you as well. >> Maybe `eglot-shutdown` shouldn't end up calling >> `eglot--signal-textDocument/didChange` at all, but that's a long >> standing behavior AFAICT, so I'll leave it for some other time. > The fix works for me. Thanks! Thanks, closing, Stefan