From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70105: 30.0.50; Emacs should support EditorConfig out of the box Date: Sun, 09 Jun 2024 00:21:28 -0400 Message-ID: References: <867chibhqi.fsf@gnu.org> <86frtnd2e6.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17409"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: jcs090218@gmail.com, bjorn.bidar@thaodan.de, 8slashes+git@gmail.com, 70105@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 09 06:22:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGA4D-0004L5-Rj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jun 2024 06:22:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGA3w-0006vS-OP; Sun, 09 Jun 2024 00:21:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGA3u-0006u9-Eb for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 00:21:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGA3u-0000rN-6o for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 00:21:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sGA4A-0005cs-2l for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 00:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2024 04:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70105 X-GNU-PR-Package: emacs Original-Received: via spool by 70105-submit@debbugs.gnu.org id=B70105.171790691421594 (code B ref 70105); Sun, 09 Jun 2024 04:22:02 +0000 Original-Received: (at 70105) by debbugs.gnu.org; 9 Jun 2024 04:21:54 +0000 Original-Received: from localhost ([127.0.0.1]:36550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGA41-0005cE-QI for submit@debbugs.gnu.org; Sun, 09 Jun 2024 00:21:54 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGA40-0005br-Ga for 70105@debbugs.gnu.org; Sun, 09 Jun 2024 00:21:52 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 81E8F100043; Sun, 9 Jun 2024 00:21:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1717906889; bh=vr/asPTRLdUflXg1J2JI6ZO3mXxcvVbZ3K3k1v9RfSc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hnL+PUDx8c491wlLhqz7RdypYq1KbAwqrjkcaDIFTBDwglUYiyBGppR+NIwfwZW2j RXwKzNddSPKnUDQqlvPAvRDJwdp9vqc6sel1fWpAVkjiyODQTUouVqhsw0AdwVCkcC htm4byFhGiQh3FHxeqyNg1Bo4KKw0VST7CgVkOlYyDJgBQWbXENwvx0iwbNyaI4JTM xlLyFoRiqHuzOlQspw3AoV7d2ii2HhQjSZopetvkY2EaZsjuXi+o0FQplXIdfpRTT9 vjXbHxggi5PUA41wYaYpzkWnX6k6NrKZyL7gRAve9myYfq5wYr+NNPV+htiNSidxlG fYcmO21RDTnHQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7C28D100035; Sun, 9 Jun 2024 00:21:29 -0400 (EDT) Original-Received: from pastel (unknown [24.140.236.196]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 30A8E12024D; Sun, 9 Jun 2024 00:21:29 -0400 (EDT) In-Reply-To: <86frtnd2e6.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Jun 2024 15:50:41 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286910 Archived-At: > Comments: > >> +** 'auto-coding-functions' can know the name of the file. >> +The functions on this hook take can now find the name of the file to > ^^^^ > The "take" part should probably be removed. > >> +@defvar hack-dir-local-get-variables-functions >> +This special hook holds the functions that gather the directory-local >> +variables to use for a given buffer. By default it contains just the >> +function that obeys the other settings described in the present section. >> +But it can be used to add support for more sources of directory-local >> +variables, such as those used by other text editors. >> + >> +The functions on this hook are called with no argument, in the buffer to >> +which we intend to apply the directory-local variables, after the >> +buffer's major mode function has been run, so it can use sources of > > I'm guessing you meant "they", not "it", because this refers to > "functions on this hook", right? > >> +directory hierarchy. Finally, since this hook is run every time we visit >> +a file it is important to try and keep those functions efficient, which >> +will usually require some of caching. > ^^^^^^^^^^^^^^^ > "some kind of caching", perhaps? Well, the upside is that the above shows the value of taking one's time when writing (I was in a bit of a hurry). Thanks, pushed, Stefan