From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74132: 31.0.50; thing-at-pt, ffap and Github markdown Date: Sat, 09 Nov 2024 10:52:06 -0500 Message-ID: References: <20241031.160649.1619221016115134543.enometh@meer.net> <86msi8n1jd.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15120"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Madhu , 74132@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 09 16:53:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t9nm2-0003k2-UD for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Nov 2024 16:53:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9nlo-0002fI-QW; Sat, 09 Nov 2024 10:53:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9nln-0002es-Db for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 10:53:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t9nln-0004Xg-38 for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 10:53:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=kb9RFsRi+R4Qa3bMW4AaP4SEY2tEt8DaC1x99rs77sM=; b=D0LTKYFqDpMSUWuE34XeHD02+EgO25VrgKHTkCUi3UGpV9DI06DX+8Sw3tdzQVMS+aj8GWvkljJJiEhLMqEIqjBkrMuzUy1Ej82PQhfzwNtjPxxXabgTovFzrNOzjun8nxhCDU9UxszHoaVQ5ObV1lu9s6PTh5N2n3nqxaaVdvaCnRqxDO8xQb+KlQIgeHIr7jvQ3LIAAjIs3VyFaf30HHiAO4Y4rr3BPeqD/+ZDmTcj1C1yEKCmxtr73P9FDjWr+97kTO0mh+KVdmzElOBMZHwbB12mp92lP7gdKI7OHNdGgo5IoHYOV270G7PbIQj9ayNJLapd5ZiJJBx4nXLf6A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t9nll-00026S-U4 for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2024 10:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Nov 2024 15:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74132 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74132-submit@debbugs.gnu.org id=B74132.17311675428015 (code B ref 74132); Sat, 09 Nov 2024 15:53:01 +0000 Original-Received: (at 74132) by debbugs.gnu.org; 9 Nov 2024 15:52:22 +0000 Original-Received: from localhost ([127.0.0.1]:54084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9nl8-00025C-Fn for submit@debbugs.gnu.org; Sat, 09 Nov 2024 10:52:22 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9nl4-00024v-Mc for 74132@debbugs.gnu.org; Sat, 09 Nov 2024 10:52:20 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 53A3880013; Sat, 9 Nov 2024 10:52:12 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1731167527; bh=iGNji/Zly401xag3fShz39YjDDOmZBIbopa1WtAEmwA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dSY3mGxLhlQQsDMxATHeWqzKKj8/fPUeS7RuyupP6Z4rh8PxHhtmDsuaLSEl9iaAe wu2kmLv8j2zvqOfmVu6SkkPb9gfoIKRzwaHAUDzHj2+KcXKrsum7UBkvLSq/cZVnZu cACfjamrZWXr5OKkYnm1cnWWyFj84zkRRFXumRI8FcDEAwmVNpUHOZlyy5+Q3SlU49 05PFnGgPpW3oiuoVkR8XBQAEdOlrXHFJ5cpeQVLNe9/l7jgs1qQ5BhP1Hfclo8E8uM yH/f1hMcIVg9tYdkIqhD8fvTJEW05UAVq14BG4YWunvbQK+d/MDKOqrZHO+WY4ndQa qYIAsZtfHa7Bw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 500678053B; Sat, 9 Nov 2024 10:52:07 -0500 (EST) Original-Received: from pastel (104-195-225-43.cpe.teksavvy.com [104.195.225.43]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 21D2C12041D; Sat, 9 Nov 2024 10:52:07 -0500 (EST) In-Reply-To: <86msi8n1jd.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Nov 2024 12:29:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295136 Archived-At: > What will this do to URLs such as > > http://web.archive.org/web/20240221082647/https://www.imdb.com/ Depends where point is: if it's after the `https`, then you get the "sub-URL" and if it's on or before the `https` then you get the whole URL. > I'm not sure I see how to resolve this dilemma. Stefan, any ideas? "url at point" is inherently heuristic, so I'm not too worried. But I do very much agree with Stefan that we need tests, because it's all too easy to run around in circles otherwise, fixing the heuristic to handle case A but breaking case B along the way. Stefan