From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.help Subject: Re: How to use defadvice without infinite loop Date: Mon, 29 Sep 2003 15:08:45 GMT Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Message-ID: References: <87d6dm1d5t.fsf@juliva.com> <87y8w8199h.fsf@juliva.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1064848978 14922 80.91.224.253 (29 Sep 2003 15:22:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 29 Sep 2003 15:22:58 +0000 (UTC) Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Mon Sep 29 17:22:56 2003 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1A3zrU-0002FQ-00 for ; Mon, 29 Sep 2003 17:22:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.22) id 1A3zkf-0004r4-Fo for geh-help-gnu-emacs@m.gmane.org; Mon, 29 Sep 2003 11:15:53 -0400 Original-Path: shelby.stanford.edu!newsfeed.stanford.edu!news-spur1.maxwell.syr.edu!news.maxwell.syr.edu!news-out1.nntp.be!propagator2-sterling!news-in-sterling.nuthinbutnews.com!snoopy.risq.qc.ca!charlie.risq.qc.ca!53ab2750!not-for-mail Original-Newsgroups: gnu.emacs.help Original-Lines: 15 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Original-NNTP-Posting-Host: 132.204.24.42 Original-X-Complaints-To: abuse@umontreal.ca Original-X-Trace: charlie.risq.qc.ca 1064848125 132.204.24.42 (Mon, 29 Sep 2003 11:08:45 EDT) Original-NNTP-Posting-Date: Mon, 29 Sep 2003 11:08:45 EDT Original-Xref: shelby.stanford.edu gnu.emacs.help:116938 Original-To: help-gnu-emacs@gnu.org X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.help:12864 X-Report-Spam: http://spam.gmane.org/gmane.emacs.help:12864 > (defadvice save-some-buffers(before my-save-some-buffers activate) > "Ask to save buffers." > (interactive) > ;; Prevent infinite loop > (ad-deactivate-regexp "my-save-some-buffers") > (save-some-buffers nil 'my-always-save) > (ad-activate-regexp "my-save-some-buffers")) You can try an `around' advice instead of a `before' advice, and then put two `ad-do-it' in there, modifying the args in between the two calls. Pretty ugly as well. Maybe the doc suggests a cleaner way to do what you want. Stefan