From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: support for rxvt-unicode in rxvt.el Date: Wed, 21 Sep 2005 13:25:22 -0400 Message-ID: References: <20050921132431.GA5008@host91-100.pool871.interbusiness.it> <200509211629.j8LGTCKE019350@scanner2.ics.uci.edu> <74205160509210943718a3746@mail.gmail.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1127324142 5608 80.91.229.2 (21 Sep 2005 17:35:42 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 21 Sep 2005 17:35:42 +0000 (UTC) Cc: Dan Nicolaescu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 21 19:35:37 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EI8Sk-00037O-Ly for ged-emacs-devel@m.gmane.org; Wed, 21 Sep 2005 19:32:55 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EI8Sj-0002is-Q8 for ged-emacs-devel@m.gmane.org; Wed, 21 Sep 2005 13:32:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EI8Ow-00018y-9n for emacs-devel@gnu.org; Wed, 21 Sep 2005 13:28:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EI8Ot-00012p-Bx for emacs-devel@gnu.org; Wed, 21 Sep 2005 13:28:56 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EI8Or-0000yN-AX for emacs-devel@gnu.org; Wed, 21 Sep 2005 13:28:53 -0400 Original-Received: from [132.204.24.67] (helo=mercure.iro.umontreal.ca) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EI8Ln-0006Lm-Am for emacs-devel@gnu.org; Wed, 21 Sep 2005 13:25:43 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 73C7F2CF590; Wed, 21 Sep 2005 13:25:34 -0400 (EDT) Original-Received: from asado.iro.umontreal.ca (asado.iro.umontreal.ca [132.204.24.84]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id CB1A34AC00A; Wed, 21 Sep 2005 13:25:22 -0400 (EDT) Original-Received: by asado.iro.umontreal.ca (Postfix, from userid 20848) id B6DB9E6C22; Wed, 21 Sep 2005 13:25:22 -0400 (EDT) Original-To: Emanuele Giaquinta In-Reply-To: <74205160509210943718a3746@mail.gmail.com> (Emanuele Giaquinta's message of "Wed, 21 Sep 2005 18:43:45 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-4.846, requis 5, autolearn=not spam, AWL 0.05, BAYES_00 -4.90) X-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:43135 Archived-At: >> The up, down, right and left key should be set from the rxvt-unicode >> terminfo entry, so you don't need those define-keys. So if you just add >> the color setting code to rxvt.el then everything should work. Can you >> verify that the above is indeed true? IMHO it is better to avoid code >> duplication... > I perfectly agree with you here; I've already tested it without > defining the sequences for the cursor keys, and, as expected, Emacs > gets them from the terminfo entry. I have added them only for > symmetry with the existing code in rxvt.el and xterm.el. If there is > no good reason, the existing definitions for the cursor keys in > rxvt.el and xterm.el could be deleted. Such key sequences have been added to xterm.el because at some point they've been found to be necessary. Maybe nowadays they're redundant. If they're not necessary for rxvt.el, better not add them. Removing them from xterm.el is more delicate since we'd need to know for sure that they're always unnecessary, otherwise we might (re)introduce bugs. Stefan "who doesn't know whether they may actually be necessary in rxvt.el in some cases" PS: Before I can install your patch, I need for someone to tell me whether I can do it: OT1H it seems you haven't signed any legal paperwork, OTOH your code is just a copy of code from xterm.el. Can I just install it as a "tiny change"?