From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [RFA] Console based mouse face highlighting. Date: Thu, 17 May 2007 10:59:36 -0400 Message-ID: References: <17989.37070.393150.565546@kahikatea.snap.net.nz> <17990.21422.577087.305723@kahikatea.snap.net.nz> <17990.37305.657724.344516@kahikatea.snap.net.nz> <17992.53379.953892.751275@kahikatea.snap.net.nz> <17993.11948.400368.430713@kahikatea.snap.net.nz> <17994.14013.614407.875104@kahikatea.snap.net.nz> <17994.32856.216525.50726@kahikatea.snap.net.nz> <17994.54868.931947.611990@kahikatea.snap.net.nz> <17995.31640.399794.621018@kahikatea.snap.net.nz> <17995.53754.860573.633945@kahikatea.snap.net.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1179413994 8903 80.91.229.12 (17 May 2007 14:59:54 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 17 May 2007 14:59:54 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Nick Roberts Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 17 16:59:50 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HohSG-0002w1-MQ for ged-emacs-devel@m.gmane.org; Thu, 17 May 2007 16:59:49 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HohaM-00063c-Um for ged-emacs-devel@m.gmane.org; Thu, 17 May 2007 11:08:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HohaK-00063N-AU for emacs-devel@gnu.org; Thu, 17 May 2007 11:08:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HohaK-00063B-0a for emacs-devel@gnu.org; Thu, 17 May 2007 11:08:08 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HohaJ-000638-R6 for emacs-devel@gnu.org; Thu, 17 May 2007 11:08:07 -0400 Original-Received: from 18.red-83-50-230.dynamicip.rima-tde.net ([83.50.230.18] helo=alfajor.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HohS7-0001Wl-VF; Thu, 17 May 2007 10:59:44 -0400 Original-Received: by alfajor.home (Postfix, from userid 20848) id ACBBD1C5B3; Thu, 17 May 2007 10:59:36 -0400 (EDT) In-Reply-To: <17995.53754.860573.633945@kahikatea.snap.net.nz> (Nick Roberts's message of "Thu\, 17 May 2007 15\:54\:34 +1200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.95 (gnu/linux) X-detected-kernel: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71254 Archived-At: >> > I can't easily add an extra argument to write_glyphs as it's called in many >> > places. >> >> But it sounds like all of them but one should be called with that >> argument zero, so it shouldn't be too hard to convert them. Am I >> missing something? > Well it means changes to write_glyphs and rif->write_glyphs in a dozen or so > places in dispnew.c, and a change to x_write_glyph in xdisp.c at least (and > perhaps w32con_write_glyphs). If you're comfortable with those changes and > still think it's the right approach, I'll do that. It doesn't seem like it'd be a big problem as such. But I do wonder why this is necessary now, even though it hasn't been necessary until now for all other places where we support mouse highlighting. So a bit of argumentation that explains why this situation is different seems in order. It might also help understand the code, so I'd recommend to put it in comments. Stefan