From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: New VC diff for review Date: Mon, 08 Oct 2007 21:51:03 -0400 Message-ID: References: <20071006152353.GA15638@thyrsus.com> <200710061938.l96JcojN020804@oogie-boogie.ics.uci.edu> <20071008225842.GA28748@thyrsus.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1191894681 16490 80.91.229.12 (9 Oct 2007 01:51:21 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 9 Oct 2007 01:51:21 +0000 (UTC) Cc: Dan Nicolaescu , emacs-devel@gnu.org To: esr@thyrsus.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 09 03:51:19 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1If4Fh-0004UT-In for ged-emacs-devel@m.gmane.org; Tue, 09 Oct 2007 03:51:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1If4Fc-0003Ym-4x for ged-emacs-devel@m.gmane.org; Mon, 08 Oct 2007 21:51:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1If4FX-0003VW-HC for emacs-devel@gnu.org; Mon, 08 Oct 2007 21:51:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1If4FW-0003U9-4H for emacs-devel@gnu.org; Mon, 08 Oct 2007 21:51:07 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1If4FV-0003U3-Tt for emacs-devel@gnu.org; Mon, 08 Oct 2007 21:51:05 -0400 Original-Received: from bc.sympatico.ca ([209.226.175.184] helo=tomts22-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1If4FW-0006JU-EP for emacs-devel@gnu.org; Mon, 08 Oct 2007 21:51:06 -0400 Original-Received: from ceviche.home ([70.55.141.81]) by tomts22-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20071009015104.SNHH18413.tomts22-srv.bellnexxia.net@ceviche.home> for ; Mon, 8 Oct 2007 21:51:04 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 3012CB40AF; Mon, 8 Oct 2007 21:51:03 -0400 (EDT) In-Reply-To: <20071008225842.GA28748@thyrsus.com> (Eric S. Raymond's message of "Mon\, 8 Oct 2007 18\:58\:43 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.50 (gnu/linux) X-Detected-Kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80449 Archived-At: >> One of these vc-diff* functions needs to do (vc-call >> revision-completion-table file) like vc-version-diff does in order to get >> completions for versions. > There's a conceptual problem here. Remember that new VC operates on > filesets, not files. If the fileset has more than one member, which file > should be used to key into the revision completion table? What's the problem: pass it the fileset and let the backend decide. >> - (expand-file-name f odefault))) >> + (if (file-name-absolute-p f) >> + f >> + (concat odefault f)))) >> files))) >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> Is this change intentional or a merge problem? It's hard to tell... Merge problem. I "recently" replaced the `if' form by the simpler `expand-file-name' call. Stefan