From: Stefan Monnier <monnier@iro.umontreal.ca>
To: esr@thyrsus.com
Cc: Dan Nicolaescu <dann@ics.uci.edu>, emacs-devel@gnu.org
Subject: Re: New VC diff for review
Date: Mon, 08 Oct 2007 21:51:03 -0400 [thread overview]
Message-ID: <jwvtzp1ukit.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20071008225842.GA28748@thyrsus.com> (Eric S. Raymond's message of "Mon\, 8 Oct 2007 18\:58\:43 -0400")
>> One of these vc-diff* functions needs to do (vc-call
>> revision-completion-table file) like vc-version-diff does in order to get
>> completions for versions.
> There's a conceptual problem here. Remember that new VC operates on
> filesets, not files. If the fileset has more than one member, which file
> should be used to key into the revision completion table?
What's the problem: pass it the fileset and let the backend decide.
>> - (expand-file-name f odefault)))
>> + (if (file-name-absolute-p f)
>> + f
>> + (concat odefault f))))
>> files)))
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> Is this change intentional or a merge problem? It's hard to tell...
Merge problem. I "recently" replaced the `if' form by the simpler
`expand-file-name' call.
Stefan
next prev parent reply other threads:[~2007-10-09 1:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-06 15:23 New VC diff for review Eric S. Raymond
2007-10-06 19:38 ` Dan Nicolaescu
2007-10-08 22:58 ` Eric S. Raymond
2007-10-09 1:51 ` Stefan Monnier [this message]
2007-10-09 10:31 ` Eric S. Raymond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtzp1ukit.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
--cc=esr@thyrsus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.