From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.50; Crash in ediff-regions-linewise Date: Tue, 16 Oct 2007 11:50:25 -0400 Message-ID: References: <87wstq5cr6.fsf@candyboy.here> <87ejfw15a2.fsf@candyboy.here> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1192549873 11233 80.91.229.12 (16 Oct 2007 15:51:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 16 Oct 2007 15:51:13 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, rms@gnu.org To: Toby Allsopp Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 16 17:51:13 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IhohE-0000Ep-SK for ged-emacs-devel@m.gmane.org; Tue, 16 Oct 2007 17:51:05 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ihoh8-0002S7-1i for ged-emacs-devel@m.gmane.org; Tue, 16 Oct 2007 11:50:58 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ihoh4-0002RO-Nf for emacs-devel@gnu.org; Tue, 16 Oct 2007 11:50:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ihoh3-0002Ql-Ao for emacs-devel@gnu.org; Tue, 16 Oct 2007 11:50:54 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ihoh3-0002Qh-4m for emacs-devel@gnu.org; Tue, 16 Oct 2007 11:50:53 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ihoh1-00027e-Su for emacs-devel@gnu.org; Tue, 16 Oct 2007 11:50:52 -0400 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ihoh1-0005fd-Gn for emacs-pretest-bug@gnu.org; Tue, 16 Oct 2007 11:50:51 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Ihogz-00026q-0u for emacs-pretest-bug@gnu.org; Tue, 16 Oct 2007 11:50:51 -0400 Original-Received: from x-132-204-255-77.xtpr.umontreal.ca ([132.204.255.77] helo=ceviche.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ihogu-000240-EZ; Tue, 16 Oct 2007 11:50:48 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 8ED54B41C1; Tue, 16 Oct 2007 11:50:25 -0400 (EDT) In-Reply-To: <87ejfw15a2.fsf@candyboy.here> (Toby Allsopp's message of "Tue\, 16 Oct 2007 09\:39\:33 +1300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81012 gmane.emacs.pretest.bugs:20144 Archived-At: >> BTW recompiling with -DENABLE_CHECKING should catch these problems earlier >> and with a more explicit failure. > This makes temacs die due to a failed assertion. See below for > details. I'm out of time to look into this further at the moment. Hmm..... not sure why I didn't bump into this, but the patch below might fix it. Stefan Index: alloc.c =================================================================== RCS file: /sources/emacs/emacs/src/alloc.c,v retrieving revision 1.427 diff -u -u -b -r1.427 alloc.c --- alloc.c 16 Oct 2007 15:42:58 -0000 1.427 +++ alloc.c 16 Oct 2007 15:48:10 -0000 @@ -4966,7 +4966,10 @@ for (i = 0; i < size; i++) vec->contents[i] = Fpurecopy (XVECTOR (obj)->contents[i]); if (COMPILEDP (obj)) + { + XSETPVECTYPE (vec, PVEC_COMPILED); XSETCOMPILED (obj, vec); + } else XSETVECTOR (obj, vec); return obj; Diffs between working revision and workfile end here.