all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Toby Allsopp <toby@mi6.gen.nz>
Cc: emacs-pretest-bug@gnu.org, rms@gnu.org
Subject: Re: 23.0.50; Crash in ediff-regions-linewise
Date: Tue, 16 Oct 2007 11:50:25 -0400	[thread overview]
Message-ID: <jwvtzorxdnn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87ejfw15a2.fsf@candyboy.here> (Toby Allsopp's message of "Tue\, 16 Oct 2007 09\:39\:33 +1300")

>> BTW recompiling with -DENABLE_CHECKING should catch these problems earlier
>> and with a more explicit failure.

> This makes temacs die due to a failed assertion.  See below for
> details.  I'm out of time to look into this further at the moment.

Hmm..... not sure why I didn't bump into this, but the patch below might
fix it.


        Stefan


Index: alloc.c
===================================================================
RCS file: /sources/emacs/emacs/src/alloc.c,v
retrieving revision 1.427
diff -u -u -b -r1.427 alloc.c
--- alloc.c	16 Oct 2007 15:42:58 -0000	1.427
+++ alloc.c	16 Oct 2007 15:48:10 -0000
@@ -4966,7 +4966,10 @@
       for (i = 0; i < size; i++)
 	vec->contents[i] = Fpurecopy (XVECTOR (obj)->contents[i]);
       if (COMPILEDP (obj))
+	{
+	  XSETPVECTYPE (vec, PVEC_COMPILED);
 	XSETCOMPILED (obj, vec);
+	}
       else
 	XSETVECTOR (obj, vec);
       return obj;


Diffs between working revision and workfile end here.

  reply	other threads:[~2007-10-16 15:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-13  7:13 23.0.50; Crash in ediff-regions-linewise Toby Allsopp
2007-10-13 19:47 ` Richard Stallman
2007-10-14  8:19   ` Toby Allsopp
2007-10-14 19:05     ` Stefan Monnier
2007-10-14 20:01       ` Andreas Schwab
2007-10-16 15:43         ` Stefan Monnier
2007-10-15 20:39       ` Toby Allsopp
2007-10-16 15:50         ` Stefan Monnier [this message]
2007-10-17  5:42           ` Toby Allsopp
2007-10-17 14:03             ` Stefan Monnier
     [not found]   ` <874pgu5bxh.fsf@candyboy.here>
2007-10-15  1:37     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtzorxdnn.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-pretest-bug@gnu.org \
    --cc=rms@gnu.org \
    --cc=toby@mi6.gen.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.