From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Introducing 'unrecognized and 'ignored Date: Sun, 20 Jan 2008 15:14:22 -0500 Message-ID: References: <17EA38DF-BCC1-4565-8510-5DD10DD667E3@mac.com> <20071229114551.GD9794@thyrsus.com> <20080102021907.GA15494@thyrsus.com> <200801020445.m024jWU2008538@oogie-boogie.ics.uci.edu> <200801031805.m03I5SBf022748@oogie-boogie.ics.uci.edu> <200801050901.m0591mQj011970@oogie-boogie.ics.uci.edu> <20080105143415.GG30869@thyrsus.com> <200801061037.m06AbIRD004966@oogie-boogie.ics.uci.edu> <200801182346.m0INkiEg022130@sallyv1.ics.uci.edu> <200801191705.m0JH5WOU026943@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1200860083 28606 80.91.229.12 (20 Jan 2008 20:14:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Jan 2008 20:14:43 +0000 (UTC) Cc: esr@thyrsus.com, harsanyi@mac.com, Dan Nicolaescu , rms@gnu.org, emacs-devel@gnu.org To: Tom Tromey Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 20 21:15:01 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JGgZH-0000Mu-4h for ged-emacs-devel@m.gmane.org; Sun, 20 Jan 2008 21:14:59 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JGgYr-0007w6-Mb for ged-emacs-devel@m.gmane.org; Sun, 20 Jan 2008 15:14:33 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JGgYo-0007vc-0c for emacs-devel@gnu.org; Sun, 20 Jan 2008 15:14:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JGgYm-0007vQ-Ky for emacs-devel@gnu.org; Sun, 20 Jan 2008 15:14:29 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JGgYm-0007vJ-Ck for emacs-devel@gnu.org; Sun, 20 Jan 2008 15:14:28 -0500 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JGgYj-0003Gq-1i; Sun, 20 Jan 2008 15:14:25 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ah4FAM86k0fO+J4pUGdsb2JhbACQDgEBOZpwfg X-IronPort-AV: E=Sophos;i="4.25,224,1199682000"; d="scan'208";a="12974629" Original-Received: from smtp.pppoe.ca ([65.39.196.238]) by ironport2-out.pppoe.ca with ESMTP; 20 Jan 2008 15:14:23 -0500 Original-Received: from pastel.home ([206.248.158.41]) by smtp.pppoe.ca (Internet Mail Server v1.0) with ESMTP id AVI25723; Sun, 20 Jan 2008 15:14:23 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id B3F967F61; Sun, 20 Jan 2008 15:14:22 -0500 (EST) In-Reply-To: (Tom Tromey's message of "Sun, 20 Jan 2008 12:08:19 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87121 Archived-At: > I hook into vc-do-command... I'm not sure if that is really a good idea. > I guess that's why we have patch review :-) I general it doesn't sound like a bad idea, but I'll reserve my judgment until I see the code. > It is also worth considering if we really want to clear the ewoc > before re-running 'status' (or, eventually, 'update'). I suspect we > don't want to. This seems to be what PCL-CVS does, and it has the > nice effect of preserving the user's marks and point during > operations. PCL-CVS used to clear the ewoc, so I obviously believe it's worth the effort to not clear it, so as to preserve mark and such. Also because you want to work on parts of a vc-status display (some backends don't like it as much as CVS, but it's still pretty common). > I think that means we need a nice way to insert a new element into the > proper position in the ewoc; maybe a new ewoc method is needed. (This > is different than updating the display incrementally, since right now > we just assume the back end hook provides the files in the right order > and we just insert them into the ewoc in that order.) Can't remember how I do it in PCL-CVS. Stefan