From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: shell-script indentation bug Date: Thu, 28 Feb 2008 16:38:18 -0500 Message-ID: References: <200802270938.48147.andreas.roehler@online.de> <87hcfsokub.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204234753 14928 80.91.229.12 (28 Feb 2008 21:39:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 28 Feb 2008 21:39:13 +0000 (UTC) Cc: andreas.roehler@online.de, emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 28 22:39:38 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JUqTF-0005VW-Ci for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2008 22:39:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUqSi-0003O2-OE for ged-emacs-devel@m.gmane.org; Thu, 28 Feb 2008 16:38:44 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUqSW-0003Fk-SV for emacs-devel@gnu.org; Thu, 28 Feb 2008 16:38:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUqSU-0003Ds-Ot for emacs-devel@gnu.org; Thu, 28 Feb 2008 16:38:32 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUqSU-0003Dm-KK for emacs-devel@gnu.org; Thu, 28 Feb 2008 16:38:30 -0500 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JUqSU-0006HV-7P for emacs-devel@gnu.org; Thu, 28 Feb 2008 16:38:30 -0500 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id C7F472CF7EF; Thu, 28 Feb 2008 16:38:29 -0500 (EST) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 26DF63FE0; Thu, 28 Feb 2008 16:38:18 -0500 (EST) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 191856CAAA; Thu, 28 Feb 2008 16:38:18 -0500 (EST) In-Reply-To: <87hcfsokub.fsf@stupidchicken.com> (Chong Yidong's message of "Thu, 28 Feb 2008 16:02:52 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:90783 Archived-At: >>> with cursor at the end of the line as shown below >> >>> if [ $# == 0 ]; then >>> ____________________|______ >> >> >>> C-j should indent. >> >> Well, I'd agree, but it's done on purpose: C-j is bound to >> sh-newline-and-indent whose docstring says: >> >> Strip unquoted whitespace, insert newline, and indent like current line. >> >> Please can someone investigate which this binding was added (what was >> it trying to fix), and then make it DTRT? > It is present in the original version of sh-script.el, 13 years ago. > I think this binding should simply be removed, and the default > (newline-and-indent) used instead. Agreed, Stefan