From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.60; isearch for M-: incorrect in Info Date: Sat, 19 Apr 2008 22:48:36 -0400 Message-ID: References: <000801c89dc4$bf3a9ee0$0200a8c0@us.oracle.com> <874pa2278i.fsf@jurta.org> <003301c89f50$35b7d7e0$0200a8c0@us.oracle.com> <87wsmwkrr9.fsf@jurta.org> <87fxth7f34.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1208659776 7425 80.91.229.12 (20 Apr 2008 02:49:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 20 Apr 2008 02:49:36 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, Drew Adams To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 20 04:50:10 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JnPd3-0007Mb-M3 for ged-emacs-devel@m.gmane.org; Sun, 20 Apr 2008 04:50:09 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JnPcO-0008Qj-JH for ged-emacs-devel@m.gmane.org; Sat, 19 Apr 2008 22:49:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JnPbg-000876-Qz for emacs-devel@gnu.org; Sat, 19 Apr 2008 22:48:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JnPbe-00086R-Tp for emacs-devel@gnu.org; Sat, 19 Apr 2008 22:48:44 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JnPbe-00086K-ET for emacs-devel@gnu.org; Sat, 19 Apr 2008 22:48:42 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JnPbe-0001DZ-F6 for emacs-devel@gnu.org; Sat, 19 Apr 2008 22:48:42 -0400 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JnPbd-0000T0-Ro for emacs-pretest-bug@gnu.org; Sat, 19 Apr 2008 22:48:41 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JnPba-0001DD-H1 for emacs-pretest-bug@gnu.org; Sat, 19 Apr 2008 22:48:42 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182] helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JnPba-0001D5-8h for emacs-pretest-bug@gnu.org; Sat, 19 Apr 2008 22:48:38 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmcFAIJLCkhMCqsI/2dsb2JhbACBUKgx X-IronPort-AV: E=Sophos;i="4.25,684,1199682000"; d="scan'208";a="18782761" Original-Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 19 Apr 2008 22:48:37 -0400 Original-Received: from pastel.home ([76.10.171.8]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id AGQ31137; Sat, 19 Apr 2008 22:48:37 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id F273B8DDE; Sat, 19 Apr 2008 22:48:36 -0400 (EDT) In-Reply-To: <87fxth7f34.fsf@jurta.org> (Juri Linkov's message of "Sun, 20 Apr 2008 01:48:55 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95504 gmane.emacs.pretest.bugs:22075 Archived-At: > + (defvar isearch-success-function nil [...] > ! (if isearch-success-function > ! (funcall isearch-success-function > ! (match-beginning 0) (match-end 0)) > ! (or (eq search-invisible t) > ! (not (isearch-range-invisible > ! (match-beginning 0) (match-end 0)))))) Better just call isearch-success-function unconditionally and move the default code to the default value of isearch-success-function. I understand that may require many more changes to your code, tho, but I think it's important to always make when you introduce such a foo-function variable to make sure that it is possible to reproduce the default value (since it's often desirable to do almost the same as the default). Stefan