From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Juri Linkov <juri@jurta.org>
Cc: emacs-pretest-bug@gnu.org, Drew Adams <drew.adams@oracle.com>
Subject: Re: 23.0.60; isearch for M-: incorrect in Info
Date: Sat, 19 Apr 2008 22:48:36 -0400 [thread overview]
Message-ID: <jwvtzhx2qid.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87fxth7f34.fsf@jurta.org> (Juri Linkov's message of "Sun, 20 Apr 2008 01:48:55 +0300")
> + (defvar isearch-success-function nil
[...]
> ! (if isearch-success-function
> ! (funcall isearch-success-function
> ! (match-beginning 0) (match-end 0))
> ! (or (eq search-invisible t)
> ! (not (isearch-range-invisible
> ! (match-beginning 0) (match-end 0))))))
Better just call isearch-success-function unconditionally and move the
default code to the default value of isearch-success-function.
I understand that may require many more changes to your code, tho, but
I think it's important to always make when you introduce such
a foo-function variable to make sure that it is possible to reproduce
the default value (since it's often desirable to do almost the same as
the default).
Stefan
next prev parent reply other threads:[~2008-04-20 2:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 0:16 23.0.60; isearch for M-: incorrect in Info Drew Adams
2008-04-15 22:29 ` Juri Linkov
2008-04-15 23:27 ` Drew Adams
2008-04-17 23:14 ` Juri Linkov
2008-04-18 20:21 ` Stefan Monnier
2008-04-19 22:48 ` Juri Linkov
2008-04-20 2:48 ` Stefan Monnier [this message]
2008-04-20 23:54 ` Juri Linkov
2008-04-21 1:05 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtzhx2qid.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=drew.adams@oracle.com \
--cc=emacs-pretest-bug@gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.