From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Yanking isearch to highlight-regexp Date: Sat, 28 Jun 2008 18:23:59 -0400 Message-ID: References: <4853F884.7000609@gmail.com> <7dbe73ed0806141442h342f8ff0u83863f3980a7e229@mail.gmail.com> <48545D78.8080103@gmail.com> <4854E536.8040407@gmail.com> <87k5gql900.fsf@jurta.org> <878wwp1an8.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1214691860 23196 80.91.229.12 (28 Jun 2008 22:24:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Jun 2008 22:24:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 29 00:25:06 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KCiqt-0007Hc-8Q for ged-emacs-devel@m.gmane.org; Sun, 29 Jun 2008 00:25:03 +0200 Original-Received: from localhost ([127.0.0.1]:37008 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KCiq2-0000Zn-W9 for ged-emacs-devel@m.gmane.org; Sat, 28 Jun 2008 18:24:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KCipz-0000ZO-6E for emacs-devel@gnu.org; Sat, 28 Jun 2008 18:24:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KCipx-0000Z3-Ng for emacs-devel@gnu.org; Sat, 28 Jun 2008 18:24:06 -0400 Original-Received: from [199.232.76.173] (port=56159 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KCipx-0000Yy-KL for emacs-devel@gnu.org; Sat, 28 Jun 2008 18:24:05 -0400 Original-Received: from 69-196-135-70.dsl.teksavvy.com ([69.196.135.70]:46116 helo=ceviche.home) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KCipx-0006hD-Ac for emacs-devel@gnu.org; Sat, 28 Jun 2008 18:24:05 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 5B6DC70033; Sat, 28 Jun 2008 18:23:59 -0400 (EDT) In-Reply-To: <878wwp1an8.fsf@jurta.org> (Juri Linkov's message of "Sun, 29 Jun 2008 01:02:03 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100105 Archived-At: > Below is a patch that unifies two similar regexp-reading functions > `keep-lines-read-args' and `occur-read-primary-args' into the general > function `read-regexp'. It reads a regexp using the regexp history > and provides some useful defaults. Like `keep-lines-read-args' > it accepts the prompt as its argument, but without the trailing colon > to be able to add the default value in parentheses. Sounds good. > But now the prompt for `keep-lines' doesn't look nice since > it displays parentheses twice as: > Keep lines (containing match for regexp) (default regexp): > maybe a better format would be: > Keep lines, containing match for regexp (default regexp): Yes, that's better, tho I'd even drop the comma. Stefan