From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: visual-line-mode Date: Fri, 11 Jul 2008 21:43:54 -0400 Message-ID: References: <87zlp4raab.fsf@catnip.gol.com> <87d4lzehq2.fsf@stupidchicken.com> <87skuqbwr8.fsf@stupidchicken.com> <85E9BC5B-7337-4CD4-A783-6B2FAEBAEBCA@gmail.com> <87tzf6c5il.fsf@stupidchicken.com> <87abgxx0ju.fsf@stupidchicken.com> <4D997CA8-A2ED-4E12-9F91-76E98AE95210@gmail.com> <87prpsjhre.fsf@stupidchicken.com> <375C0006-2B47-4B1F-9EB2-ED47941C2DB3@gmail.com> <87od56tp4o.fsf@stupidchicken.com> <71C2D50C-1680-4ADD-A7E3-7B7A1146B85D@gmail.com> <87ej61n19h.fsf@stupidchicken.com> <87vdzdr6f6.fsf@catnip.gol.com> <87d4lknn4i.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1215827053 32164 80.91.229.12 (12 Jul 2008 01:44:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 12 Jul 2008 01:44:13 +0000 (UTC) Cc: David Reitter , Emacs-Devel devel , "Lennart Borgman \(gmail\)" , Miles Bader To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 12 03:45:00 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KHUAU-00011D-V7 for ged-emacs-devel@m.gmane.org; Sat, 12 Jul 2008 03:44:59 +0200 Original-Received: from localhost ([127.0.0.1]:38999 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KHU9d-000896-83 for ged-emacs-devel@m.gmane.org; Fri, 11 Jul 2008 21:44:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KHU9Y-00088v-Lt for emacs-devel@gnu.org; Fri, 11 Jul 2008 21:44:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KHU9X-00088j-2c for emacs-devel@gnu.org; Fri, 11 Jul 2008 21:43:59 -0400 Original-Received: from [199.232.76.173] (port=53434 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KHU9W-00088b-Tb for emacs-devel@gnu.org; Fri, 11 Jul 2008 21:43:58 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:32209 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KHU9T-0001bs-EM; Fri, 11 Jul 2008 21:43:55 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AnEDAA+pd0jO+IfCdGdsb2JhbACBWpBSASeXSYFo X-IronPort-AV: E=Sophos;i="4.30,348,1212379200"; d="scan'208";a="24250445" Original-Received: from 206-248-135-194.dsl.teksavvy.com (HELO pastel.home) ([206.248.135.194]) by ironport2-out.teksavvy.com with ESMTP; 11 Jul 2008 21:43:54 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 1F548897A; Fri, 11 Jul 2008 21:43:54 -0400 (EDT) In-Reply-To: <87d4lknn4i.fsf@stupidchicken.com> (Chong Yidong's message of "Fri, 11 Jul 2008 17:10:05 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100599 Archived-At: >> PS: My patch is just a proof of concept. It has a few bugs. One of >> them can be seen when you set truncate-lines, in which case it doesn't >> preserve columns correctly (basically, its temporary-goal-column ends >> up being computed from the beginning of the displayed part of the line, >> so as long as hscroll is not changed, it works OK but as soon as >> hscroll is modified, the result is incorrect). > Does the following patch give good results/make sense? Not sure. I'm not sure where is the bug, really. If it's in posn-point, or in vertical-motion, or simply in my Elisp code, or a combination. My gut feeling is that there's at least a bug in my Elisp code and maybe also in the vertical-motion code (the part that handles horizontal position, i.e. my new code there). It looks like your patch presumes that the Elisp code is passing the correct value, which I'm not sure is the case. But it's probably going in the right direction. Stefan