From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#1286: comment-dwim on a comment line does not toggle comment Date: Tue, 04 Nov 2008 11:34:33 -0500 Message-ID: References: <200811031125.mA3BP8eZ024503@zogzog.maillard.mobi> <244A228E-2192-4165-8495-C760C253DE9E@xahlee.org> Reply-To: Stefan Monnier , 1286@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1225817440 18975 80.91.229.12 (4 Nov 2008 16:50:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Nov 2008 16:50:40 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org, 1286@emacsbugs.donarmstrong.com, bug-submit-list@donarmstrong.com To: xah lee Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 04 17:51:41 2008 connect(): Connection refused Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from mail-forward1.uio.no ([129.240.10.70]) by lo.gmane.org with esmtp (Exim 4.50) id 1KxP7m-0008OX-1H for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Nov 2008 17:51:26 +0100 Original-Received: from exim by mail-out1.uio.no with local-bsmtp (Exim 4.69) (envelope-from ) id 1KxP6f-0002YZ-Fy for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Nov 2008 17:50:17 +0100 Original-Received: from mail-mx4.uio.no ([129.240.10.45]) by mail-out1.uio.no with esmtp (Exim 4.69) (envelope-from ) id 1KxP6f-0002YW-Ep for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Nov 2008 17:50:17 +0100 Original-Received: from lists.gnu.org ([199.232.76.165]) by mail-mx4.uio.no with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1KxP6e-0005Kz-NS for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Nov 2008 17:50:17 +0100 Original-Received: from localhost ([127.0.0.1]:48477 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KxP6d-0005PT-PQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Nov 2008 11:50:15 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KxP6a-0005On-6C for bug-gnu-emacs@gnu.org; Tue, 04 Nov 2008 11:50:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KxP6Y-0005OO-L5 for bug-gnu-emacs@gnu.org; Tue, 04 Nov 2008 11:50:11 -0500 Original-Received: from [199.232.76.173] (port=43578 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KxP6Y-0005OK-Hu for bug-gnu-emacs@gnu.org; Tue, 04 Nov 2008 11:50:10 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:38750) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KxP6Y-00068z-AA for bug-gnu-emacs@gnu.org; Tue, 04 Nov 2008 11:50:10 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA4Go5hp006224; Tue, 4 Nov 2008 08:50:05 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mA4Ge4Ja003824; Tue, 4 Nov 2008 08:40:04 -0800 X-Loop: don@donarmstrong.com Resent-From: Stefan Monnier Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 04 Nov 2008 16:40:04 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1286 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12258164922441 (code B ref -1); Tue, 04 Nov 2008 16:40:04 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 4 Nov 2008 16:34:52 +0000 Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mA4GYnvr002435 for ; Tue, 4 Nov 2008 08:34:50 -0800 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KxOrg-00008i-UD for bug-gnu-emacs@gnu.org; Tue, 04 Nov 2008 11:34:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KxOrf-00008N-GF for bug-gnu-emacs@gnu.org; Tue, 04 Nov 2008 11:34:48 -0500 Original-Received: from [199.232.76.173] (port=48570 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KxOrf-00008K-Ak for bug-gnu-emacs@gnu.org; Tue, 04 Nov 2008 11:34:47 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:47565) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KxOre-0003lW-BL; Tue, 04 Nov 2008 11:34:46 -0500 Original-Received: from alfajor.home (vpn-132-204-232-40.acd.umontreal.ca [132.204.232.40]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id mA4GZ7hI003160; Tue, 4 Nov 2008 11:35:09 -0500 Original-Received: by alfajor.home (Postfix, from userid 20848) id 264041C44D; Tue, 4 Nov 2008 11:34:33 -0500 (EST) In-Reply-To: <244A228E-2192-4165-8495-C760C253DE9E@xahlee.org> (xah lee's message of "Mon, 3 Nov 2008 13:10:24 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3139=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-CrossAssassin-Score: 2 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Tue, 04 Nov 2008 11:50:11 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org X-UiO-SPF-Received: Received-SPF: pass (mail-mx4.uio.no: domain of gnu.org designates 199.232.76.165 as permitted sender) client-ip=199.232.76.165; envelope-from=bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org; helo=lists.gnu.org; X-UiO-Spam-info: not spam, SpamAssassin (score=-4.0, required=5.0, autolearn=disabled, MISSING_SUBJECT=0.001,NO_RECEIVED=-0.001,RCVD_IN_DNSWL_MED=-4, uiobl=NO, uiouri=NO) X-UiO-Scanned: 958A3267C13A56DD569BAF0E5661EE316454914D X-UiO-SPAM-Test: remote_host: 199.232.76.165 spam_score: -39 maxlevel 200 minaction 2 bait 0 mail/h: 31 total 76010 max/h 424 blacklist 0 greylist 0 ratelimit 0 Xref: news.gmane.org gmane.emacs.bugs:22157 Archived-At: > when a cursor is on a comment line (whole line is comment) and there's no > active region, i don't see any reason it shouldn't just uncomment the line > when calling comment-dwim. I would say that, any person, including those I, on the other hand, don't see why it should do that. What would be the logic behind it? And according to that logic what should it do if the line contains a comment as well as some code? As explained, the M-; behavior you're seeing has been with us for many many years, so there needs to be a good reason for the change (and the previous behavior of inserting a comment marker and/or reindenting a preexisting comment marker, should still be available somewhere). Stefan