From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: NS: ns-expand-space / slider in Preferences dialog not functional Date: Tue, 10 Mar 2009 11:59:11 -0400 Message-ID: References: <21F51971-5679-45BF-85A0-D982CA73E722@gmail.com> <5393D476-3312-4DF3-AF39-6D698B7FDA49@gmail.com> <06CD0A2A-6B89-4E1A-BBA6-E91F03A289DD@gmail.com> <200903092315.n29NFcrh021453@rodan.ics.uci.edu> <200903101533.n2AFXIBL000661@rodan.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236731901 4403 80.91.229.12 (11 Mar 2009 00:38:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Mar 2009 00:38:21 +0000 (UTC) Cc: Miles Bader , David Reitter , Adrian Robert , YAMAMOTO Mitsuharu , Emacs-Devel devel To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 11 01:39:37 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LhCTw-0005ME-AJ for ged-emacs-devel@m.gmane.org; Wed, 11 Mar 2009 01:39:36 +0100 Original-Received: from localhost ([127.0.0.1]:52223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhCSa-0003QP-Jw for ged-emacs-devel@m.gmane.org; Tue, 10 Mar 2009 20:38:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LhCQv-00023h-N4 for emacs-devel@gnu.org; Tue, 10 Mar 2009 20:36:29 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LhCQv-000231-10 for emacs-devel@gnu.org; Tue, 10 Mar 2009 20:36:29 -0400 Original-Received: from [199.232.76.173] (port=33594 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LhCQu-00022s-TB for emacs-devel@gnu.org; Tue, 10 Mar 2009 20:36:28 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:57170 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LhCQt-0000SI-2E; Tue, 10 Mar 2009 20:36:27 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhIFAMektklFxL+1/2dsb2JhbACBTtBrhA0GhCWCSA X-IronPort-AV: E=Sophos;i="4.38,338,1233550800"; d="scan'208";a="35013185" Original-Received: from 69-196-191-181.dsl.teksavvy.com (HELO ceviche.home) ([69.196.191.181]) by ironport2-out.teksavvy.com with ESMTP; 10 Mar 2009 20:36:24 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 19336B4265; Tue, 10 Mar 2009 11:59:11 -0400 (EDT) In-Reply-To: <200903101533.n2AFXIBL000661@rodan.ics.uci.edu> (Dan Nicolaescu's message of "Tue, 10 Mar 2009 08:33:18 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109549 Archived-At: >> > /* FIXME: Because of the typo below, Qbuffered probably never did >> > anything useful, so it might as well be removed. */ >> > Qbuffered = intern ("bufferd"); >> > staticpro (&Qbuffered); >> > ??? Whis is this kept around? >> >> Feel free to remove such dead code. >> >> > Qfontsize = intern ("fontsize"); >> > staticpro (&Qfontsize); >> > What about this one? >> >> What about it? > Isn't dealing with font sizes supposed to be cross-platform? > font.c: font_open_for_lface > [snip] > #ifdef HAVE_NS > if (size == 0) > { > Lisp_Object ffsize = get_frame_param(f, Qfontsize); > size = NUMBERP (ffsize) ? POINT_TO_PIXEL (XINT (ffsize), f->resy) : 0; > } > #endif Yes, but I don't know what this piece of code is supposed to do. It can probably be removed. Stefan