From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Andreas Roehler <andreas.roehler@online.de>
Cc: emacs-devel@gnu.org, "Eric M. Ludlam" <eric@siege-engine.com>,
XEmacs-Beta@xemacs.org
Subject: Re: simplifying beginning-of-defun
Date: Mon, 28 Sep 2009 18:46:51 -0400 [thread overview]
Message-ID: <jwvtyym8zjl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4AC05C9A.2010802@online.de> (Andreas Roehler's message of "Mon, 28 Sep 2009 08:50:02 +0200")
>> I was pointing out incompatibilities.
> Can't see any. If you write
>>>> Apparently it makes beginning-of-defun-raw ignore
>>>> beginning-of-defun-function,
> it should do exactly that IMHO.
Maybe it should, maybe it shouuldn't. My point is that it currently
does whereas in your patch it doesn't, so that's an incompatibility.
That doesn't mean it's a problem, just a place that requires
careful attention.
> Why not let modes say what they want and need? An argument must not mean a
> repeat BTW. In python-mode is a selection to deliver too.
end-of-defun's docstring says "With argument, do it that many times", so
if a major mode uses it for other purposes, it's abusing it. It would
probably be better in such a case to just define a new command and remap
keys to that new command.
>>> Mentioned code of a end-of-defun-function in lisp.el is a bug.
>>> Suggest to cancel it.
>> I do not know which code nor which bug you talking about. Your code?
>> Emacs's code?
> from GNU lisp.el.
> "(defvar end-of-defun-function
> (lambda () ...."
> Giving it a value here, it will be called. Which is
> to avoid, as only languages-modes should set and use it.
Who says?
> This setting reintroduces all the mess,
> beginning/end-of-defun-function are invented for.
I do not know what you're referring to.
>>> Funcalls of beginning-of-defun-function, end-of-defun-function should
>>> be reserved for progmodes.
>> I have no idea what you mean by "progmodes".
> Modes of other programming languages than emacs-lisp
Why would such a concept matter here? emacs-lisp-mode should not be
treated specially.
>>> BTW if mode-specific, probably it should be introduced as a local var
>>> from the very beginning?
>> I'm not sure I understand. Are you suggesting we
>> (make-varible-buffer-local 'beginning-of-defun-function)?
> Yes, that's the question. I.e it should be mode-specific, in any case
> not global.
It's definitely meant to be buffer-local. That doesn't mean there
shouldn't be a meaningful default for those buffers which don't want to
bother to set it themselves.
Stefan
next prev parent reply other threads:[~2009-09-28 22:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-26 17:52 simplifying beginning-of-defun Andreas Roehler
2009-09-26 21:44 ` Stefan Monnier
2009-09-27 8:10 ` Andreas Roehler
2009-09-27 18:40 ` Stefan Monnier
2009-09-28 6:50 ` Andreas Roehler
2009-09-28 22:46 ` Stefan Monnier [this message]
2009-09-29 6:53 ` Andreas Roehler
2009-09-29 8:29 ` Andreas Roehler
2009-09-27 10:26 ` Andreas Roehler
2009-09-27 11:17 ` Eric M. Ludlam
2009-09-27 18:53 ` Stefan Monnier
2009-09-27 20:07 ` Eric M. Ludlam
2009-09-27 22:52 ` Stefan Monnier
2009-09-28 2:04 ` Eric M. Ludlam
2009-09-28 4:06 ` Stefan Monnier
2009-09-28 11:20 ` Eric M. Ludlam
2009-09-29 6:50 ` Alan Mackenzie
2009-09-27 19:06 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtyym8zjl.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=XEmacs-Beta@xemacs.org \
--cc=andreas.roehler@online.de \
--cc=emacs-devel@gnu.org \
--cc=eric@siege-engine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.