From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Add notifications.el Date: Wed, 09 Jun 2010 16:39:33 -0400 Message-ID: References: <1275757657-15244-1-git-send-email-julien@danjou.info> <201006092018.10163.tassilo@member.fsf.org> <87ocfkkpgg.fsf@keller.adm.naquadah.org> <201006092116.46374.tassilo@member.fsf.org> <87ljaoyom4.fsf@keller.adm.naquadah.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1276116176 31338 80.91.229.12 (9 Jun 2010 20:42:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 9 Jun 2010 20:42:56 +0000 (UTC) Cc: Tassilo Horn , emacs-devel@gnu.org To: Julien Danjou Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 09 22:42:53 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OMS6q-0005mO-3z for ged-emacs-devel@m.gmane.org; Wed, 09 Jun 2010 22:42:48 +0200 Original-Received: from localhost ([127.0.0.1]:49873 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMS6p-0007Fh-5x for ged-emacs-devel@m.gmane.org; Wed, 09 Jun 2010 16:42:47 -0400 Original-Received: from [140.186.70.92] (port=43249 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMS3k-0004ve-M3 for emacs-devel@gnu.org; Wed, 09 Jun 2010 16:39:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OMS3j-0007h2-Df for emacs-devel@gnu.org; Wed, 09 Jun 2010 16:39:36 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:27387 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OMS3j-0007gw-Bq for emacs-devel@gnu.org; Wed, 09 Jun 2010 16:39:35 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAEuYD0xFxIMM/2dsb2JhbACeU3K/EYUYBIxw X-IronPort-AV: E=Sophos;i="4.53,393,1272859200"; d="scan'208";a="67708616" Original-Received: from 69-196-131-12.dsl.teksavvy.com (HELO ceviche.home) ([69.196.131.12]) by ironport2-out.pppoe.ca with ESMTP; 09 Jun 2010 16:39:34 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id F2F7A660D4; Wed, 9 Jun 2010 16:39:33 -0400 (EDT) In-Reply-To: <87ljaoyom4.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Wed, 09 Jun 2010 21:47:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125686 Archived-At: > What about adding: > :on-close > `(lambda (reason) > (when (eq reason 'dismissed) > (puthash ,body -1 th-notify-body-to-id-map))) > in `args' ? Just so I understand better the trade-off: what would it take to pass `id' to the on-close function? Stefan PS: the process-filters and process-sentinels all could keep track of the process to which they're connected, but we found it convenient to pass the process object as an argument instead. So based on that precedent, it would not seem out-of-place to pass the `id' to the on-close function.