* bug#6487: using vc-annotate-find-revision-at-line for renamed/removed files @ 2010-06-21 20:41 Dan Nicolaescu 2010-06-22 0:33 ` Stefan Monnier 2010-06-24 18:31 ` Dan Nicolaescu 0 siblings, 2 replies; 4+ messages in thread From: Dan Nicolaescu @ 2010-06-21 20:41 UTC (permalink / raw) To: 6487 vc-annotate for git and mercurial shows the original file name for a change, even if the file has been renamed meanwhile. Using `vc-annotate-find-revision-at-line' on such a line in the annotate does not work vc-annotate-find-revision-at-line calls vc-find-revision for a file that does not exist anymore. vc-find-revision in turn does a: (vc-call find-revision file revision outbuf) but given that the file does not exist anymore, no VC backend claims the file, so the vc-call fails vc-annotate-find-revision-at-line knows what VC backend it needs to call, so it could pass it as an optional argument to vc-find-revision. ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#6487: using vc-annotate-find-revision-at-line for renamed/removed files 2010-06-21 20:41 bug#6487: using vc-annotate-find-revision-at-line for renamed/removed files Dan Nicolaescu @ 2010-06-22 0:33 ` Stefan Monnier 2010-06-22 2:55 ` Dan Nicolaescu 2010-06-24 18:31 ` Dan Nicolaescu 1 sibling, 1 reply; 4+ messages in thread From: Stefan Monnier @ 2010-06-22 0:33 UTC (permalink / raw) To: Dan Nicolaescu; +Cc: 6487 > vc-annotate-find-revision-at-line knows what VC backend it needs to > call, so it could pass it as an optional argument to vc-find-revision. Indeed, vc-call relies on `vc-backend' which we usually should try to avoid calling (since usually the context already tells us which backend to use and using another one would actually be an error). Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#6487: using vc-annotate-find-revision-at-line for renamed/removed files 2010-06-22 0:33 ` Stefan Monnier @ 2010-06-22 2:55 ` Dan Nicolaescu 0 siblings, 0 replies; 4+ messages in thread From: Dan Nicolaescu @ 2010-06-22 2:55 UTC (permalink / raw) To: Stefan Monnier; +Cc: 6487 Stefan Monnier <monnier@iro.umontreal.ca> writes: >> vc-annotate-find-revision-at-line knows what VC backend it needs to >> call, so it could pass it as an optional argument to vc-find-revision. > > Indeed, vc-call relies on `vc-backend' which we usually should try to > avoid calling (since usually the context already tells us which backend > to use and using another one would actually be an error). vc-annotate has the same problem when called from vc-annotate-warp-revision. ^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#6487: using vc-annotate-find-revision-at-line for renamed/removed files 2010-06-21 20:41 bug#6487: using vc-annotate-find-revision-at-line for renamed/removed files Dan Nicolaescu 2010-06-22 0:33 ` Stefan Monnier @ 2010-06-24 18:31 ` Dan Nicolaescu 1 sibling, 0 replies; 4+ messages in thread From: Dan Nicolaescu @ 2010-06-24 18:31 UTC (permalink / raw) To: 6487-done Fixed in emacs-23 branch. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-06-24 18:31 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-06-21 20:41 bug#6487: using vc-annotate-find-revision-at-line for renamed/removed files Dan Nicolaescu 2010-06-22 0:33 ` Stefan Monnier 2010-06-22 2:55 ` Dan Nicolaescu 2010-06-24 18:31 ` Dan Nicolaescu
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.