From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 1/1] compile.el bug in recognizing -o switches among Date: Fri, 29 Oct 2010 13:32:30 -0400 Message-ID: References: <5e0d0f4adb8ef5510aeacb9bcbe9a1a7.squirrel@xspect.dk> <93ede5c63f6ca7272e5b0feb43e929f4.squirrel@xspect.dk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1288373566 11196 80.91.229.12 (29 Oct 2010 17:32:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 29 Oct 2010 17:32:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Jes Bodi Klinke" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 29 19:32:43 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PBsok-0005tf-M6 for ged-emacs-devel@m.gmane.org; Fri, 29 Oct 2010 19:32:42 +0200 Original-Received: from localhost ([127.0.0.1]:58851 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBsoj-0007eA-W8 for ged-emacs-devel@m.gmane.org; Fri, 29 Oct 2010 13:32:42 -0400 Original-Received: from [140.186.70.92] (port=51632 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBsoa-0007bh-TQ for emacs-devel@gnu.org; Fri, 29 Oct 2010 13:32:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PBsoZ-0007dt-Ir for emacs-devel@gnu.org; Fri, 29 Oct 2010 13:32:32 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:24878 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PBsoZ-0007dp-E2 for emacs-devel@gnu.org; Fri, 29 Oct 2010 13:32:31 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgwKACyiykzO+Krc/2dsb2JhbACgVn1yv1OFSASSKg X-IronPort-AV: E=Sophos;i="4.58,260,1286164800"; d="scan'208";a="81051705" Original-Received: from 206-248-170-220.dsl.teksavvy.com (HELO ceviche.home) ([206.248.170.220]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 29 Oct 2010 13:32:30 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 0AB9A660F5; Fri, 29 Oct 2010 13:32:30 -0400 (EDT) In-Reply-To: (Jes Bodi Klinke's message of "Thu, 28 Oct 2010 12:43:26 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132174 Archived-At: >>> (by adding an outer pair of parentheses). The correct regex is: >>> " -\\(?:o[= ]?\\|-\\(?:outfile\\|output\\)[= ]\\)\\(\\S +\\)" >> Thanks, installed. >> But, could you tell me how you made your patches? >> Neither diff-mode nor `patch' understand their format: > Thank you. Responses like this to my feedback encourages me to spend more > time on Emacs the next time. Thanks. > About the patch. I manually edited the output from bzr diff. I deleted > what I thought was a comment line. It looked like bzr had tried to > extract the name of the enclosing function, but it had failed badly and > pulled out part of an unrelated text literal. I thought that letting it > be could confuse human readers of the patch, but I guess I should have > just deleted the text to the right of the ***********, not the entire > line. That was not specific to Bzr but to diff in general (controlled by the "-p" flag) which just uses the last line that starts in column 0 as a very simple heuristic. So "patch" knows to ignore whatever follows the ***************, and people used to reading context diffs also know to ignore it. FWIW, I usually prefer the unified context diff format (not that it makes much difference in this case since it can also have this extra "show function line" text). Stefan