From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#7343: Making flyspell incredibly fast when checking whole files Date: Mon, 08 Nov 2010 13:10:42 -0500 Message-ID: References: <874obu5z1z.fsf@asaph.rhodesmill.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1289240045 1324 80.91.229.12 (8 Nov 2010 18:14:05 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 8 Nov 2010 18:14:05 +0000 (UTC) Cc: Agustin Martin , 7343@debbugs.gnu.org To: Brandon Craig Rhodes Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 08 19:14:00 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PFWE8-0003gE-8Z for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Nov 2010 19:13:56 +0100 Original-Received: from localhost ([127.0.0.1]:56714 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFWE6-0000I2-GH for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Nov 2010 13:13:54 -0500 Original-Received: from [140.186.70.92] (port=60070 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PFWDx-0000GS-Ad for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2010 13:13:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PFWDw-0000Fh-1S for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2010 13:13:45 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54452) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PFWDv-0000FY-W9 for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2010 13:13:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PFW7S-00075b-G5; Mon, 08 Nov 2010 13:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Nov 2010 18:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7343 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7343-submit@debbugs.gnu.org id=B7343.128923957027243 (code B ref 7343); Mon, 08 Nov 2010 18:07:02 +0000 Original-Received: (at 7343) by debbugs.gnu.org; 8 Nov 2010 18:06:10 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFW6b-00075M-MK for submit@debbugs.gnu.org; Mon, 08 Nov 2010 13:06:09 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PFW6Z-00075H-G7 for 7343@debbugs.gnu.org; Mon, 08 Nov 2010 13:06:08 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtEKAJDL10xMCpqE/2dsb2JhbAChCIECcr1GhUgEhFiNWg X-IronPort-AV: E=Sophos;i="4.59,169,1288584000"; d="scan'208";a="81943336" Original-Received: from 76-10-154-132.dsl.teksavvy.com (HELO pastel.home) ([76.10.154.132]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 08 Nov 2010 13:10:42 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 7F140A86D8; Mon, 8 Nov 2010 13:10:42 -0500 (EST) In-Reply-To: <874obu5z1z.fsf@asaph.rhodesmill.org> (Brandon Craig Rhodes's message of "Sat, 06 Nov 2010 10:03:52 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 08 Nov 2010 13:07:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41436 Archived-At: > Anyway, flyspell does try to take advantage of the above behavior by > checking whether a region is larger than flyspell-large-region > characters, and if so then it runs the spell checker as a separate > process with "-l". But then it does something that, in many cases, is > rather ruinous: it takes every misspelling so identified, and passes it > *back* through the normal interactive spell-checking logic! This is > because all of the real logic of what to do with a misspelling - how to > highlight it, how to search for nearby instances of the same word, how > to cache spellings, and so forth - is bound up in flyspell-word, so the > flyspell-external-point-words function, which processes the actual > misspellings discovered by flyspell-large-region, really has no other > choice but to call flyspell-word for each misspelling. IIUC this sounds very good (tho it only speeds up flyspell-region and not flyspell-post-command-hook) and the patch looks good and small enough for inclusion as a "tiny patch". Agustin, could you double check that it's OK and install it in the trunk if so? Stefan