From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: "Jérémy Compostella" <jeremy.compostella@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] window.el: Improve mark management
Date: Tue, 24 Jan 2012 15:31:25 -0500 [thread overview]
Message-ID: <jwvty3k7slq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CA+TATJH630kd=uQ70d=Mpv4FxKu0Q46D1-JYZ83DDBu+db5sxA@mail.gmail.com> ("Jérémy Compostella"'s message of "Sat, 21 Jan 2012 15:36:21 +0100")
>> >> I'm not completely sure. The current code doesn't seem that bad since,
>> >> as you say, it basically reproduces the behavior of
>> >> window-configurations.
>> >> So I'd like to first hear of what are concrete cases where the current
>> >> behavior is a problem.
>> > It's very simple : with the current code, when you call the
>> > `window-state-put' function, the mark is restored as active.
>> That's easy to fix: use (set-marker (mark-marker)) instead of set-mark.
> Interesting.
It's actually a trivial bug-fix.
>> > - Either, remove all the mark stuff from `window-state-get' and
>> > `window-state-put' functions.
>> That's not a bad idea, actually.
> Yes that's was my first idea in fact. After this discussion I think
> it's the good thing to do and ou I attached the corresponding patch to
> this email. `window-state-get' and `window-state-put' should not deal
> with mark as it's not relevant at all and leads to an unexpected
> behavior from user point of view.
I tend to agree. Martin, what do you think?
Stefan
next prev parent reply other threads:[~2012-01-24 20:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 19:43 [PATCH] window.el: Improve mark management Jérémy Compostella
2012-01-20 10:01 ` martin rudalics
2012-01-20 13:42 ` Stefan Monnier
2012-01-20 15:13 ` martin rudalics
2012-01-20 16:11 ` Stefan Monnier
2012-01-20 16:52 ` Jérémy Compostella
2012-01-20 18:25 ` Stefan Monnier
2012-01-21 14:36 ` Jérémy Compostella
2012-01-24 20:31 ` Stefan Monnier [this message]
2012-01-25 10:32 ` martin rudalics
2012-01-25 13:45 ` Stefan Monnier
2012-01-25 15:01 ` Jérémy Compostella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvty3k7slq.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jeremy.compostella@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.