From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Aaron S. Hawley" <aaron.s.hawley@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: locate-file-completion-table: Fixed point from lexical-binding?
Date: Thu, 23 Feb 2012 01:27:06 -0500 [thread overview]
Message-ID: <jwvty2iw4kl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAFw1JJ5gjo0gLMUiRrBz3_wohX_9BrcnMd=Qj=WMyY8TCfStXg@mail.gmail.com> (Aaron S. Hawley's message of "Wed, 22 Feb 2012 12:38:55 -0500")
> The problem started after revision 103798. This patch seems to fix
> the issue for me.
Good catch, thank you. Once again, `setq' bites.
I installed the fix below which should work as well but avoids the use
of setq instead.
Stefan
=== modified file 'lisp/minibuffer.el'
--- lisp/minibuffer.el 2012-02-15 13:45:02 +0000
+++ lisp/minibuffer.el 2012-02-23 04:31:34 +0000
@@ -226,9 +226,10 @@
(defun completion-table-with-context (prefix table string pred action)
;; TODO: add `suffix' maybe?
+ (let ((pred
+ (if (not (functionp pred))
;; Notice that `pred' may not be a function in some abusive cases.
- (when (functionp pred)
- (setq pred
+ pred
;; Predicates are called differently depending on the nature of
;; the completion table :-(
(cond
@@ -240,7 +241,7 @@
(lambda (s) (funcall pred (concat prefix s))))
(t ;Lists and alists.
(lambda (s)
- (funcall pred (concat prefix (if (consp s) (car s) s))))))))
+ (funcall pred (concat prefix (if (consp s) (car s) s)))))))))
(if (eq (car-safe action) 'boundaries)
(let* ((len (length prefix))
(bound (completion-boundaries string table pred (cdr action))))
@@ -249,7 +250,7 @@
(cond
;; In case of try-completion, add the prefix.
((stringp comp) (concat prefix comp))
- (t comp)))))
+ (t comp))))))
(defun completion-table-with-terminator (terminator table string pred action)
"Construct a completion table like TABLE but with an extra TERMINATOR.
prev parent reply other threads:[~2012-02-23 6:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 21:47 locate-file-completion-table: Fixed point from lexical-binding? Aaron S. Hawley
2012-02-22 17:38 ` Aaron S. Hawley
2012-02-23 6:27 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvty2iw4kl.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=aaron.s.hawley@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.