all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 11381@debbugs.gnu.org
Subject: bug#11381: 23.3; isearch-search-and-update issue?
Date: Mon, 28 May 2012 15:34:35 -0400	[thread overview]
Message-ID: <jwvtxz0un6o.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83pq9o1f9s.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 28 May 2012 18:44:47 +0300")

>> > Comparing two functions can be avoided by using properties
>> > on function symbols like in the patch below.
>> It's not perfect, but yes, it's much better.
> Actually, I very much dislike this "feature" of putting properties on
> function symbols, or at least the way we use it.

Agreed, hence the "not perfect".

> I say, either we start documenting these properties in the doc strings
> and in the manual, or we should deprecate and discourage the practice
> of using them.

For delsel, I think the answer is to not use properties (which is why
I insisted we use another mechanism for the shift-select and
delete-active-region thingies).

For the case at hand, it's more difficult to fold the functionality
directly into the function (that would make us turn those functions
into object-like functions, along the lines of what we do for
completion tables).

And, I agree that the docstring of isearch-search-fun-function should
then clearly document what the `isearch-message-prefix' means.


        Stefan





  parent reply	other threads:[~2012-05-28 19:34 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-29 22:31 bug#11381: 23.3; isearch-search-and-update issue? Andy Grover
2012-04-30  0:27 ` Juri Linkov
2012-05-01  9:03 ` Juri Linkov
2012-05-01 13:08   ` Stefan Monnier
2012-05-01 15:17     ` Juri Linkov
2012-05-15 21:35       ` Juri Linkov
2012-05-16  2:35         ` Stefan Monnier
2012-05-17  0:08           ` Juri Linkov
2012-05-20  0:15             ` Juri Linkov
2012-05-21  1:36               ` Stefan Monnier
2012-05-21  2:23                 ` Stefan Monnier
2012-05-27  9:43                   ` Juri Linkov
2012-05-28  4:48                     ` Stefan Monnier
2012-05-28  8:55                       ` Juri Linkov
2012-05-28 14:08                         ` Stefan Monnier
2012-05-29  9:49                           ` Juri Linkov
2012-05-29 13:34                             ` Stefan Monnier
2012-05-27  9:35                 ` Juri Linkov
2012-05-28  4:23                   ` Stefan Monnier
2012-05-28 15:44                     ` Eli Zaretskii
2012-05-28 17:34                       ` use and doc of function symbol properties [was: bug#11381: 23.3; isearch-search-and-update issue?] Drew Adams
2012-05-28 17:53                         ` Eli Zaretskii
2012-05-28 18:26                           ` Drew Adams
2012-05-28 20:43                             ` Eli Zaretskii
2012-05-30  0:10                               ` Drew Adams
2012-06-02 16:47                                 ` Eli Zaretskii
2012-06-02 16:57                                   ` Drew Adams
2012-06-02 17:52                                     ` Drew Adams
2012-05-28 17:34                       ` bug#11381: " Drew Adams
2012-05-28 19:34                       ` Stefan Monnier [this message]
2012-05-29  0:27                         ` bug#11381: 23.3; isearch-search-and-update issue? Juri Linkov
2012-05-29  1:26                           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtxz0un6o.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=11381@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.