From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] POSIX ACL support Date: Mon, 19 Nov 2012 13:11:55 -0500 Message-ID: References: <878v9yr1h1.fsf@silenus.orebokech.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: ger.gmane.org 1353348752 31537 80.91.229.3 (19 Nov 2012 18:12:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 19 Nov 2012 18:12:32 +0000 (UTC) Cc: Romain Francoise , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 19 19:12:43 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TaVpq-0007V5-7a for ged-emacs-devel@m.gmane.org; Mon, 19 Nov 2012 19:12:42 +0100 Original-Received: from localhost ([::1]:33651 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaVpc-0000Qz-Li for ged-emacs-devel@m.gmane.org; Mon, 19 Nov 2012 13:12:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaVpU-0000QT-JB for emacs-devel@gnu.org; Mon, 19 Nov 2012 13:12:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TaVpL-0004yG-2w for emacs-devel@gnu.org; Mon, 19 Nov 2012 13:12:18 -0500 Original-Received: from relais.videotron.ca ([24.201.245.36]:19217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaVpK-0004rM-V6; Mon, 19 Nov 2012 13:12:11 -0500 Original-Received: from ceviche.home ([24.201.208.110]) by VL-VM-MR006.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MDQ00JR7YJWTT30@VL-VM-MR006.ip.videotron.ca>; Mon, 19 Nov 2012 13:11:56 -0500 (EST) Original-Received: by ceviche.home (Postfix, from userid 20848) id 0947F660FF; Mon, 19 Nov 2012 13:11:56 -0500 (EST) In-reply-to: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 24.201.245.36 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:154962 Archived-At: >> The following patch adds support for preserving POSIX ACL entries of >> files, which at the moment are lost when Emacs saves a buffer (unless >> `backup-by-copying' is set). > Thanks for writing this. It is definitely needed IMO. >> -(defun backup-buffer-copy (from-name to-name modes context) >> +(defun backup-buffer-copy (from-name to-name modes context acl) > [and several other such] > This is really a general comment, not an issue with your patch in > particular, so don't let it distract. I just wonder if it is possible to > find a different way to pass this information around, so that we don't > need to have an ever increasing list of function arguments and return > values (preserve-this, preserve-that, preserve-the-other, etc...). > I don't have a good suggestion for how to do that. > (I have a vague memory this was mentioned when SELinux was added.) Yes, that's a problem. We should consolidate `modes', `context', and `acl' into a `metadata' argument. Stefan