From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#15332: Keystrokes's immediate echo only works every other time Date: Tue, 10 Sep 2013 22:41:37 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1378867343 7081 80.91.229.3 (11 Sep 2013 02:42:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Sep 2013 02:42:23 +0000 (UTC) To: 15332-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 11 04:42:23 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VJaNp-0001TG-3o for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Sep 2013 04:42:21 +0200 Original-Received: from localhost ([::1]:60945 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJaNo-0002Hs-Q4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 Sep 2013 22:42:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJaNe-0002Hi-6K for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 22:42:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJaNW-0007ve-SS for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 22:42:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJaNW-0007vY-PY for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 22:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VJaNW-0006hR-Ho for bug-gnu-emacs@gnu.org; Tue, 10 Sep 2013 22:42:02 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Sep 2013 02:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 15332 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 15332@debbugs.gnu.org, monnier@iro.umontreal.ca, monnier@iro.umontreal.ca Original-Received: via spool by 15332-done@debbugs.gnu.org id=D15332.137886731025728 (code D ref 15332); Wed, 11 Sep 2013 02:42:02 +0000 Original-Received: (at 15332-done) by debbugs.gnu.org; 11 Sep 2013 02:41:50 +0000 Original-Received: from localhost ([127.0.0.1]:53909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJaNJ-0006gt-G5 for submit@debbugs.gnu.org; Tue, 10 Sep 2013 22:41:49 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:14789) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VJaNH-0006gY-28 for 15332-done@debbugs.gnu.org; Tue, 10 Sep 2013 22:41:47 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFG4rxBo/2dsb2JhbABEuzWDWRdzgh4BAQQBVigLCzQSFBgNiEIGsR+QDo1hgykDpHqBXoMT X-IPAS-Result: Av8EABK/CFG4rxBo/2dsb2JhbABEuzWDWRdzgh4BAQQBVigLCzQSFBgNiEIGsR+QDo1hgykDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="27222860" Original-Received: from 184-175-16-104.dsl.teksavvy.com (HELO ceviche.home) ([184.175.16.104]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Sep 2013 22:38:15 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id B6719660FB; Tue, 10 Sep 2013 22:41:37 -0400 (EDT) In-Reply-To: (Stefan Monnier's message of "Tue, 10 Sep 2013 22:26:33 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78202 Archived-At: > You'll see keystrokes echo as follows: > C-u- (correct) > C-u 5 (instead of "C-u 5-") > C-u 5 5- (only appears after you wait echo-keystrokes seconds) > C-u 5 5 5 (instead of "C-u 5 5 5-") > C-u 5 5 5 5- (only appears after you wait echo-keystrokes seconds) > ... > This worked correctly in 22.3 but is broken at least since 23.4. The patch below appears to fix it. Stefan === modified file 'src/keyboard.c' --- src/keyboard.c 2013-09-09 12:15:45 +0000 +++ src/keyboard.c 2013-09-11 02:27:54 +0000 @@ -2596,9 +2596,7 @@ if (/* There currently is something in the echo area. */ !NILP (echo_area_buffer[0]) - && (/* And it's either not from echoing. */ - !EQ (echo_area_buffer[0], echo_message_buffer) - /* Or it's an echo from a different kboard. */ + && (/* It's an echo from a different kboard. */ || echo_kboard != current_kboard /* Or we explicitly allow overwriting whatever there is. */ || ok_to_echo_at_next_pause == NULL))