all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: 15332-done@debbugs.gnu.org
Subject: bug#15332: Keystrokes's immediate echo only works every other time
Date: Tue, 10 Sep 2013 22:41:37 -0400	[thread overview]
Message-ID: <jwvtxhsyta4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwvmwnkw0ti.fsf@iro.umontreal.ca> (Stefan Monnier's message of "Tue, 10 Sep 2013 22:26:33 -0400")

> You'll see keystrokes echo as follows:

>    C-u-          (correct)
>    C-u 5         (instead of "C-u 5-")
>    C-u 5 5-      (only appears after you wait echo-keystrokes seconds)
>    C-u 5 5 5     (instead of "C-u 5 5 5-")
>    C-u 5 5 5 5-  (only appears after you wait echo-keystrokes seconds)
>    ...

> This worked correctly in 22.3 but is broken at least since 23.4.
   
The patch below appears to fix it.


        Stefan


=== modified file 'src/keyboard.c'
--- src/keyboard.c	2013-09-09 12:15:45 +0000
+++ src/keyboard.c	2013-09-11 02:27:54 +0000
@@ -2596,9 +2596,7 @@
 
   if (/* There currently is something in the echo area.  */
       !NILP (echo_area_buffer[0])
-      && (/* And it's either not from echoing.  */
-	  !EQ (echo_area_buffer[0], echo_message_buffer)
-	  /* Or it's an echo from a different kboard.  */
+      && (/* It's an echo from a different kboard.  */
 	  || echo_kboard != current_kboard
 	  /* Or we explicitly allow overwriting whatever there is.  */
 	  || ok_to_echo_at_next_pause == NULL))






      reply	other threads:[~2013-09-11  2:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11  2:26 bug#15332: Keystrokes's immediate echo only works every other time Stefan Monnier
2013-09-11  2:41 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtxhsyta4.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=15332-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.