From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#15478: cc-mode does not obey electric-indent-mode Date: Wed, 02 Oct 2013 21:50:06 -0400 Message-ID: References: <20130928201147.GC11317@acm.acm> <20130929091017.GA3161@acm.acm> <20131002200737.GA3895@acm.acm> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1380765083 22934 80.91.229.3 (3 Oct 2013 01:51:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Oct 2013 01:51:23 +0000 (UTC) Cc: 15478@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 03 03:51:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VRY4X-0006En-4P for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2013 03:51:21 +0200 Original-Received: from localhost ([::1]:39429 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRY4W-0008AL-Fr for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Oct 2013 21:51:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRY4M-00089O-ID for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 21:51:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRY4E-0000iT-W7 for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 21:51:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRY4E-0000iO-SV for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 21:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VRY4E-0004e7-HV for bug-gnu-emacs@gnu.org; Wed, 02 Oct 2013 21:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2013 01:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15478-submit@debbugs.gnu.org id=B15478.138076501217801 (code B ref 15478); Thu, 03 Oct 2013 01:51:02 +0000 Original-Received: (at 15478) by debbugs.gnu.org; 3 Oct 2013 01:50:12 +0000 Original-Received: from localhost ([127.0.0.1]:50726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VRY3P-0004d3-PV for submit@debbugs.gnu.org; Wed, 02 Oct 2013 21:50:12 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:52056) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VRY3M-0004ct-CI for 15478@debbugs.gnu.org; Wed, 02 Oct 2013 21:50:10 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFsoXM//2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDpHqBXoMT X-IPAS-Result: Av4EABK/CFFsoXM//2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="34635061" Original-Received: from 108-161-115-63.dsl.teksavvy.com (HELO pastel.home) ([108.161.115.63]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Oct 2013 21:46:45 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 91F1063B99; Wed, 2 Oct 2013 21:50:06 -0400 (EDT) In-Reply-To: <20131002200737.GA3895@acm.acm> (Alan Mackenzie's message of "Wed, 2 Oct 2013 20:07:37 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:78873 Archived-At: > Without electricity, correct indentation would require continual pressing > of the key. Yes. Just as is the case in all major modes. > "|" indicates the position of point. Now type "{". With electricity, > the "{" is instantly indented to its correct position under the "if". > Without electricity, the user needs to remember to type before C-j > on L4. This is an unacceptable default state, IMAO. That's because *you* like electric-indent-mode. Not because C is special. >> Most major modes don't enable electric-layout by default (and AFAICT >> most users care more about "indent after newline", which cc-mode >> doesn't enable anyway). > "Indent after newline" seems redundant in CC Mode; Redundancy is not a problem, AFAIK. In my case, for example, CC-mode's electric indentation on {, }, and semi-colon is redundant, because I hit TAB anyway without even thinking about it (and C-x C-s very soon after that ;-). > Are you saying that, in CC Mode, users would prefer electric > indentation on the C-j rather than the semicolon, etc.? No. I'm saying that if they like electric indentation on {, }, and ;, then they probably also like it on RET. And in my experience, beginning users ask a lot more about "how do I get Emacs to put point at the right place after RET" than after any other key. > Such a change could involve extensive work Could be. And maybe not only in CC-mode but also in electric.el. > the electric behaviour is coded individually in defuns like > `c-electric-brace' and includes more electric behaviour than just > indentation - for example, auto-newlining. `electric-layout-mode' provides similar functionality, IIUC. > As an exercise, yes. But disregarding existing behaviour should not be > done frivolously; CC Mode's electric behaviour has been remarkably > stable, with (as far as I am aware) only one complaint about it (not > counting the current one) in at least 12 years (see below). There's been several request to "turn off indentation" over the years (usually answered with something like "set c-syntactic-indentation") which would not have occurred without those electric keys: it's easy to rebind TAB or avoid hitting TAB, but if after that "random other keys" keep insisting on indenting for you, it gets very frustrating. >> For me, I'd like cc-mode to do as little as possible besides adding >> ?\;, ?\{, and ?\} to electric-indent-chars. > These characters should not trigger electric indentation when typed > inside a string or a comment. electric-indent-mode isn't best placed to > make such distinctions. Why not? > It doesn't seem to be the Right Thing to split the electric activity > between electric-indent-mode (for indentation) and c-electric-brace > and friends (for auto-newlining and clean-ups). As explained, there's electric-layout-mode for auto-newlining. Not sure what "clean-ups" is about, but we can probably work something out. > I think electric-indent-mode, as it currently is, is capable of > improvement. It is a single flag, but really needs to be major-mode > dependent; it fouls up Python indentation (unless that's been recently > fixed) and I think I recall reading that it messed up something in > Outline Mode; yet CC Mode needs electricity. electric-indent-mode needs > to be buffer local. I'm all for improving electric-indent-mode. And indeed, it needs improvement for indentation-sensitive modes like Python and Haskell. > Each major mode needs its own default for e-i-m: I disagree with it: some major modes need their own default because their syntax has something very special, e.g. incompatible with electric-indent-mode (Python/Coffescript/Haskell), but most modes should just obey the default setting which reflects the user's preference. > something like `electric-indent-mode-alist', analogous with > `auto-mode-alist'. This default would be consulted at mode > initialisation time. I don't see why the major mode can't just set a var in its major-mode function for the rare cases where it can be needed, and why the user can't make his own choice via the major-mode's hook, if needed. > A buffer's setting of e-i-m should also be more than just nil or t. That > is inflexible to an un-Emacs like degree. At the very least, there > should be some sort of setting that means "electric indentation is > performed entirely by the major mode". I don't understand what you're suggesting. Stefan