From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10772: 24.0.93; [patch] Convert tcl-auto-fill-mode to use define-minor-mode Date: Wed, 26 Feb 2014 10:40:58 -0500 Message-ID: References: <87fwektsb4.fsf@gmail.com> <87r4y1pezt.fsf@gmail.com> <87vbw35nhe.fsf@gnu.org> <87ob1u3k48.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1393429340 30255 80.91.229.3 (26 Feb 2014 15:42:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Feb 2014 15:42:20 +0000 (UTC) Cc: William Stevenson , 10772@debbugs.gnu.org To: Xue Fuqiao Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 26 16:42:28 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WIgcs-0006Hf-Es for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Feb 2014 16:42:26 +0100 Original-Received: from localhost ([::1]:41368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIgcs-0004TO-3B for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Feb 2014 10:42:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIgcg-0004JQ-My for bug-gnu-emacs@gnu.org; Wed, 26 Feb 2014 10:42:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIgcV-0005Ou-6r for bug-gnu-emacs@gnu.org; Wed, 26 Feb 2014 10:42:14 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIgcV-0005O7-3G for bug-gnu-emacs@gnu.org; Wed, 26 Feb 2014 10:42:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WIgcU-0000gC-KK for bug-gnu-emacs@gnu.org; Wed, 26 Feb 2014 10:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Feb 2014 15:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10772 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10772-submit@debbugs.gnu.org id=B10772.13934292762529 (code B ref 10772); Wed, 26 Feb 2014 15:42:02 +0000 Original-Received: (at 10772) by debbugs.gnu.org; 26 Feb 2014 15:41:16 +0000 Original-Received: from localhost ([127.0.0.1]:41445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WIgbi-0000eg-88 for submit@debbugs.gnu.org; Wed, 26 Feb 2014 10:41:15 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:61813) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WIgbT-0000e1-Va for 10772@debbugs.gnu.org; Wed, 26 Feb 2014 10:41:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpaMk/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFFpaMk/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="48805257" Original-Received: from 69-165-163-36.dsl.teksavvy.com (HELO pastel.home) ([69.165.163.36]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Feb 2014 10:40:58 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 956E0601A0; Wed, 26 Feb 2014 10:40:58 -0500 (EST) In-Reply-To: <87ob1u3k48.fsf@gnu.org> (Xue Fuqiao's message of "Wed, 26 Feb 2014 06:25:43 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86258 Archived-At: >>> What about the following patch: >> Tcl is not special wrt to filling and comments, AFAIK, so tcl-mode >> should simply use the default auto-fill functionality without any >> local tweaks. > Right, and that's exactly what my patch does. No, it preserves the "special behavior", just changing the implementation to rely on the generic auto-fill code. My point is that the special behavior is just a preference of the mode's author and hence doesn't belong in the major mode's definition. Stefan