From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#19645: 25.0.50; Recent EIEIO changes broke helm: Lisp error: (cl-no-next-method helm--setup-source... Date: Wed, 21 Jan 2015 11:03:34 -0500 Message-ID: References: <87sif4txdv.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1421856583 25658 80.91.229.3 (21 Jan 2015 16:09:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Jan 2015 16:09:43 +0000 (UTC) Cc: 19645@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 21 17:09:41 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YDxqY-0002cf-7s for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Jan 2015 17:09:34 +0100 Original-Received: from localhost ([::1]:48987 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDxqX-0006Ch-IB for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Jan 2015 11:09:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDxlG-0005tF-80 for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:04:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDxlC-0006Ti-LX for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:04:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDxlC-0006Tb-J7 for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YDxlB-0004QG-VD for bug-gnu-emacs@gnu.org; Wed, 21 Jan 2015 11:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jan 2015 16:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19645 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19645-submit@debbugs.gnu.org id=B19645.142185622316974 (code B ref 19645); Wed, 21 Jan 2015 16:04:01 +0000 Original-Received: (at 19645) by debbugs.gnu.org; 21 Jan 2015 16:03:43 +0000 Original-Received: from localhost ([127.0.0.1]:52019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDxkt-0004Ph-78 for submit@debbugs.gnu.org; Wed, 21 Jan 2015 11:03:43 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:50913) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YDxkq-0004PV-Vo for 19645@debbugs.gnu.org; Wed, 21 Jan 2015 11:03:41 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjwKAOwQflSnWBWM/2dsb2JhbABbgwdSWoI0xGCGFwQCAoEkFwEBAQEBAXyEAwEBAwFWIwULCw4mBwsUGA0kiEoJDdZMAQEBAQEFAQEBAQEdkG8HhEgFiwGmJoI3gWIhgncBAQE X-IPAS-Result: AjwKAOwQflSnWBWM/2dsb2JhbABbgwdSWoI0xGCGFwQCAoEkFwEBAQEBAXyEAwEBAwFWIwULCw4mBwsUGA0kiEoJDdZMAQEBAQEFAQEBAQEdkG8HhEgFiwGmJoI3gWIhgncBAQE X-IronPort-AV: E=Sophos;i="5.07,502,1413259200"; d="scan'208";a="108376933" Original-Received: from 167-88-21-140.cpe.teksavvy.com (HELO pastel.home) ([167.88.21.140]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 21 Jan 2015 11:03:35 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 03FE312A9; Wed, 21 Jan 2015 11:03:34 -0500 (EST) In-Reply-To: <87sif4txdv.fsf@gnu.org> (Tassilo Horn's message of "Wed, 21 Jan 2015 08:18:20 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98545 Archived-At: > helm-bbdb.el:22:1:Error: No next method for %S: helm--setup-source, > nil, [eieio-class-tag--helm-type-file... It appears that you're calling helm--setup-source with an object of type helm-type-file, but the only method that matches is a ":before" method, so after running the before method, you get an error because there's no primary. IIUC the error should be `cl-no-primary-method' instead of `cl-no-next-method' (according to http://www.cliki.net/Proposed%20ANSI%20Revisions%20and%20Clarifications). >From what I can tell, the older EIEIO code just silently did nothing in this case, treating the missing primary as a function that just returns nil, but I think this is a mistake. I'm not sure how to preserve the compatibility with this mistake. I'll see if I can come up with something, but in any case I think you should fix Helm by making sure there is some primary method defined in this case as well. Stefan