From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: GNU Elpa Theme (ahungry-theme) - should I add code to auto load-theme it? Date: Thu, 05 Feb 2015 15:48:32 -0500 Message-ID: References: <87iofo7xfo.fsf@ahungry.com> <87mw4sdzi0.fsf@ahungry.com> <87d25odtai.fsf@ahungry.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423169337 14572 80.91.229.3 (5 Feb 2015 20:48:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 Feb 2015 20:48:57 +0000 (UTC) Cc: Artur Malabarba , emacs-devel To: Matthew Carter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 05 21:48:55 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJTM6-0005aX-SW for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 21:48:55 +0100 Original-Received: from localhost ([::1]:45559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJTM6-0001xu-2C for ged-emacs-devel@m.gmane.org; Thu, 05 Feb 2015 15:48:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJTLs-0001xS-Ah for emacs-devel@gnu.org; Thu, 05 Feb 2015 15:48:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJTLp-0005JC-4B for emacs-devel@gnu.org; Thu, 05 Feb 2015 15:48:40 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:35498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJTLp-0005Iu-02 for emacs-devel@gnu.org; Thu, 05 Feb 2015 15:48:37 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t15KmWHW023864; Thu, 5 Feb 2015 15:48:32 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 99EF9F5F; Thu, 5 Feb 2015 15:48:32 -0500 (EST) In-Reply-To: <87d25odtai.fsf@ahungry.com> (Matthew Carter's message of "Thu, 05 Feb 2015 14:58:45 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5208=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5208> : inlines <2040> : streams <1385332> : uri <1847384> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182479 Archived-At: > By coder and bug, are you referring to my ahungry-theme ELPA package, or > the author of the deftheme components/package built into emacs 24? I'm not familiar enough with the custom-theme code to be able to answer that yet, sorry. > My theme has 3 calls in it: > (deftheme ahungry) > (custom-theme-set-faces 'ahungry ) > (provide-theme 'ahungry) That looks sane. Do you know which one ends up activating that theme? I'd guess it's custom-theme-set-faces. Is there some other way to set the faces of a particular theme without activating that theme? > In most cases, a user has zero reason to #'require the theme unless they > plan to load it, It's difficult to change the behavior between `load' and `require' and a `load' can happen as a side-effect of something else, so by convention we want loading to have "no" side-effect (of course, that's ill-defined since loading a file has nothing but side-effects, but what is meant is that the side-effects are minor such as providing new things (commands/functions/...) rather than modifying existing ones). Not all files follow this convention, but over the years, we've tried to get closer to the ideal. Stefan