From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20141: 24.4.91; Helm is broken after last changes in eieio Date: Thu, 19 Mar 2015 10:20:26 -0400 Message-ID: References: <87fv918t1l.fsf@gmail.com> <87h9thpldv.fsf@gmail.com> <871tklmqam.fsf@gnu.org> <87lhitwj2r.fsf@web.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426774887 332 80.91.229.3 (19 Mar 2015 14:21:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Mar 2015 14:21:27 +0000 (UTC) Cc: 20141@debbugs.gnu.org, Tassilo Horn , Thierry Volpiatto To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 19 15:21:17 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYbK0-00015S-Jm for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Mar 2015 15:21:16 +0100 Original-Received: from localhost ([::1]:39413 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYbJz-0000ZB-T3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Mar 2015 10:21:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYbJr-0000W8-7J for bug-gnu-emacs@gnu.org; Thu, 19 Mar 2015 10:21:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYbJm-0005VZ-7g for bug-gnu-emacs@gnu.org; Thu, 19 Mar 2015 10:21:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYbJm-0005VV-4y for bug-gnu-emacs@gnu.org; Thu, 19 Mar 2015 10:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YYbJl-0006Lq-Oj for bug-gnu-emacs@gnu.org; Thu, 19 Mar 2015 10:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Mar 2015 14:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20141-submit@debbugs.gnu.org id=B20141.142677483924379 (code B ref 20141); Thu, 19 Mar 2015 14:21:01 +0000 Original-Received: (at 20141) by debbugs.gnu.org; 19 Mar 2015 14:20:39 +0000 Original-Received: from localhost ([127.0.0.1]:53149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYbJI-0006Ku-FZ for submit@debbugs.gnu.org; Thu, 19 Mar 2015 10:20:38 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:45688) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YYbJF-0006Kf-0R for 20141@debbugs.gnu.org; Thu, 19 Mar 2015 10:20:30 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t2JEKQhk023725; Thu, 19 Mar 2015 10:20:27 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id CDAD4114B; Thu, 19 Mar 2015 10:20:26 -0400 (EDT) In-Reply-To: <87lhitwj2r.fsf@web.de> (Michael Heerdegen's message of "Thu, 19 Mar 2015 08:19:08 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5250=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5250> : inlines <2442> : streams <1408077> : uri <1884672> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:100657 Archived-At: > (eieio-class-slots 'helm-source) [...] > Until today it returned (name), now, you get > ([cl-struct-cl-slot-descriptor name nil t nil]) eieio-class-slots is new in Emacs-25, so it's OK if it's different from yesterday. But indeed, it looks I failed to adapt object-slots. Does the patch below fix the problems people are seeing? Stefan diff --git a/lisp/emacs-lisp/eieio.el b/lisp/emacs-lisp/eieio.el index 4ba6769..8d76df8 100644 --- a/lisp/emacs-lisp/eieio.el +++ b/lisp/emacs-lisp/eieio.el @@ -453,10 +453,11 @@ The CLOS function `class-direct-subclasses' is aliased to this function." (mapcar #'identity (eieio--class-slots class))) (defun object-slots (obj) - "Return list of slots available in OBJ." + "Return list of slot names available in OBJ." (declare (obsolete eieio-class-slots "25.1")) (cl-check-type obj eieio-object) - (eieio-class-slots (eieio--object-class obj))) + (mapcar #'cl--slot-descriptor-name + (eieio-class-slots (eieio--object-class obj)))) (defun eieio--class-slot-initarg (class slot) "Fetch from CLASS, SLOT's :initarg."