all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 20141@debbugs.gnu.org, Tassilo Horn <tsdh@gnu.org>,
	Thierry Volpiatto <thierry.volpiatto@gmail.com>
Subject: bug#20141: 24.4.91; Helm is broken after last changes in eieio
Date: Thu, 19 Mar 2015 10:20:26 -0400	[thread overview]
Message-ID: <jwvtwxh5av0.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87lhitwj2r.fsf@web.de> (Michael Heerdegen's message of "Thu, 19 Mar 2015 08:19:08 +0100")

> (eieio-class-slots 'helm-source)
[...]
> Until today it returned (name), now, you get
> ([cl-struct-cl-slot-descriptor name nil t nil])

eieio-class-slots is new in Emacs-25, so it's OK if it's different
from yesterday.  But indeed, it looks I failed to adapt object-slots.
Does the patch below fix the problems people are seeing?


        Stefan


diff --git a/lisp/emacs-lisp/eieio.el b/lisp/emacs-lisp/eieio.el
index 4ba6769..8d76df8 100644
--- a/lisp/emacs-lisp/eieio.el
+++ b/lisp/emacs-lisp/eieio.el
@@ -453,10 +453,11 @@ The CLOS function `class-direct-subclasses' is aliased to this function."
   (mapcar #'identity (eieio--class-slots class)))
 
 (defun object-slots (obj)
-  "Return list of slots available in OBJ."
+  "Return list of slot names available in OBJ."
   (declare (obsolete eieio-class-slots "25.1"))
   (cl-check-type obj eieio-object)
-  (eieio-class-slots (eieio--object-class obj)))
+  (mapcar #'cl--slot-descriptor-name
+	  (eieio-class-slots (eieio--object-class obj))))
 
 (defun eieio--class-slot-initarg (class slot)
   "Fetch from CLASS, SLOT's :initarg."





  parent reply	other threads:[~2015-03-19 14:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19  5:17 bug#20141: 24.4.91; Helm is broken after last changes in eieio Thierry Volpiatto
2015-03-19  6:05 ` Ivan Shmakov
2015-03-19  6:12   ` Thierry Volpiatto
2015-03-19  7:20     ` Ivan Shmakov
2015-03-19  6:11 ` Thierry Volpiatto
2015-03-19  6:53   ` Tassilo Horn
2015-03-19  7:19     ` Michael Heerdegen
2015-03-19  8:10       ` Michael Heerdegen
2015-03-19 14:20       ` Stefan Monnier [this message]
2015-03-19 15:46         ` Tassilo Horn
2015-03-19 19:22           ` Stefan Monnier
2015-03-19 18:37         ` Thierry Volpiatto
2015-03-19 20:00           ` Stefan Monnier
2015-03-19  6:55 ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtwxh5av0.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=20141@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=thierry.volpiatto@gmail.com \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.