From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 7466a4d: Cygwin emacsclient handles w32 file names Date: Tue, 30 Jun 2015 09:56:44 -0400 Message-ID: References: <20150630005924.5663.80677@vcs.savannah.gnu.org> <5592018D.7070303@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1435672636 10686 80.91.229.3 (30 Jun 2015 13:57:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 30 Jun 2015 13:57:16 +0000 (UTC) Cc: "Michael R. Mauger" , emacs-devel@gnu.org To: Ken Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 30 15:57:05 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z9w22-0005BF-G9 for ged-emacs-devel@m.gmane.org; Tue, 30 Jun 2015 15:57:02 +0200 Original-Received: from localhost ([::1]:47149 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9w22-0004t6-0R for ged-emacs-devel@m.gmane.org; Tue, 30 Jun 2015 09:57:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9w1w-0004pr-S4 for emacs-devel@gnu.org; Tue, 30 Jun 2015 09:56:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9w1s-0007Dd-NM for emacs-devel@gnu.org; Tue, 30 Jun 2015 09:56:56 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:58474) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9w1s-0007DF-JR for emacs-devel@gnu.org; Tue, 30 Jun 2015 09:56:52 -0400 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t5UDujvo007225; Tue, 30 Jun 2015 09:56:45 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 0225E660ED; Tue, 30 Jun 2015 09:56:44 -0400 (EDT) In-Reply-To: <5592018D.7070303@cornell.edu> (Ken Brown's message of "Mon, 29 Jun 2015 22:40:13 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5353=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5353> : inlines <3303> : streams <1463973> : uri <1972997> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187670 Archived-At: >> + (when (and (eq system-type 'cygwin) >> + (fboundp 'cygwin-convert-file-name-from-windows)) > There's no need for the 'fboundp ...' here; > cygwin-convert-file-name-from-windows is defined in all Cygwin builds. I'm not arguing for or against this test, but I'm just pointing out that the test should have the benefit of silencing the byte-compiler when compiling on a non-Cygwin machine. Stefan