* Re: [Emacs-diffs] master ff2f35f: Add TeX defaults for prettify-symbol-mode
[not found] ` <E1ZSgwI-0002OL-9w@vcs.savannah.gnu.org>
@ 2015-08-21 13:35 ` Stefan Monnier
2015-08-21 16:30 ` Tassilo Horn
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Monnier @ 2015-08-21 13:35 UTC (permalink / raw)
To: emacs-devel; +Cc: Tassilo Horn
> + (setq-local prettify-symbols-compose-predicate #'tex--prettify-symbols-compose-p)
Oh, and we should use add-function here.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Emacs-diffs] master ff2f35f: Add TeX defaults for prettify-symbol-mode
2015-08-21 13:35 ` [Emacs-diffs] master ff2f35f: Add TeX defaults for prettify-symbol-mode Stefan Monnier
@ 2015-08-21 16:30 ` Tassilo Horn
2015-08-21 17:22 ` Stefan Monnier
0 siblings, 1 reply; 5+ messages in thread
From: Tassilo Horn @ 2015-08-21 16:30 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> + (setq-local prettify-symbols-compose-predicate #'tex--prettify-symbols-compose-p)
>
> Oh, and we should use add-function here.
I don't understand. Should `prettify-symbols-compose-predicate' not be
buffer-local by default but instead one should use
(add-function :override (local 'prettigy-symbols-compose-predicate)
#'tex--prettify-symbols-compose-p)
to override it on a per-buffer basis?
Bye,
Tassilo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Emacs-diffs] master ff2f35f: Add TeX defaults for prettify-symbol-mode
2015-08-21 16:30 ` Tassilo Horn
@ 2015-08-21 17:22 ` Stefan Monnier
2015-08-21 17:27 ` Drew Adams
2015-08-21 18:04 ` Tassilo Horn
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Monnier @ 2015-08-21 17:22 UTC (permalink / raw)
To: emacs-devel
> I don't understand. Should `prettify-symbols-compose-predicate' not be
> buffer-local by default but instead one should use
I don't have an opinion on whether it should be "automatically
buffer-local" or not, but:
> (add-function :override (local 'prettigy-symbols-compose-predicate)
> #'tex--prettify-symbols-compose-p)
Yes, that's what I meant (tho with "prettigy" => "prettify", of course)
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [Emacs-diffs] master ff2f35f: Add TeX defaults for prettify-symbol-mode
2015-08-21 17:22 ` Stefan Monnier
@ 2015-08-21 17:27 ` Drew Adams
2015-08-21 18:04 ` Tassilo Horn
1 sibling, 0 replies; 5+ messages in thread
From: Drew Adams @ 2015-08-21 17:27 UTC (permalink / raw)
To: Stefan Monnier, emacs-devel
> Yes, that's what I meant (tho with "prettigy" => "prettify", of
> course)
I prefer "prettigy".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master ff2f35f: Add TeX defaults for prettify-symbol-mode
2015-08-21 17:22 ` Stefan Monnier
2015-08-21 17:27 ` Drew Adams
@ 2015-08-21 18:04 ` Tassilo Horn
1 sibling, 0 replies; 5+ messages in thread
From: Tassilo Horn @ 2015-08-21 18:04 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I don't understand. Should `prettify-symbols-compose-predicate' not
>> be buffer-local by default but instead one should use
>
> I don't have an opinion on whether it should be "automatically
> buffer-local" or not, but:
I left it automatically buffer-local in order not to cause issues when a
user wants to use his own predicate and uses `setq'.
>> (add-function :override (local 'prettigy-symbols-compose-predicate)
>> #'tex--prettify-symbols-compose-p)
>
> Yes, that's what I meant (tho with "prettigy" => "prettify", of
> course)
Don't prohibit my creativity!
I'll push it anytime soon together with the etc/NEWS entry.
Bye,
Tassilo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-08-21 18:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150821074038.9159.7628@vcs.savannah.gnu.org>
[not found] ` <E1ZSgwI-0002OL-9w@vcs.savannah.gnu.org>
2015-08-21 13:35 ` [Emacs-diffs] master ff2f35f: Add TeX defaults for prettify-symbol-mode Stefan Monnier
2015-08-21 16:30 ` Tassilo Horn
2015-08-21 17:22 ` Stefan Monnier
2015-08-21 17:27 ` Drew Adams
2015-08-21 18:04 ` Tassilo Horn
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.