all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: jostein@kjonigsen.net (Jostein Kjønigsen)
Cc: 21496@debbugs.gnu.org, janneke@gnu.org
Subject: bug#21496: 25.0.50; guile-file compilation-error regexp is too wide
Date: Wed, 16 Sep 2015 17:52:05 -0400	[thread overview]
Message-ID: <jwvtwquvya1.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87oah2sp3y.fsf@kjonigsen.net> ("Jostein Kjønigsen"'s message of "Wed, 16 Sep 2015 11:14:09 +0200")

>      In csharp--at-vsemi-p:
[...]
> The problem is that all these headers are picked up by the guile-file
> compilation-error-regexp entry which is extremely wide:

>     (guile-file "^In \\(.+\\):\n" 1)

I was thinking of the patch below, which does two things:
1- lower the importance of those "In blabla:" from "error" to "info".
2- limit the .* to be either something that ends in .scm, or something
   that has a slash (or backslash for w32), or something without spaces.

But I see that "something without spaces" is not strict enough, so we
should drop it.  Maybe "something that ends in .scm" is good enough?


        Stefan


diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index a6e9ed8..24b7e63 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -477,7 +477,11 @@ File = \\(.+\\), Line = \\([0-9]+\\)\\(?:, Column = \\([0-9]+\\)\\)?"
      ;;
      "^\\([^ \t\r\n(]+\\) (\\([0-9]+\\):\\([0-9]+\\)) "
      1 2 3)
-    (guile-file "^In \\(.+\\):\n" 1)
+    (guile-file
+     ;; Try to make sure it's a file name so as not to match unrelated
+     ;; text such as "In end of data" or "In top level form" (bug#21496).
+     "^In \\(.+\\.scm\\|.+[/\\].*\\|[^ \n\t]+\\):\n"
+     1 nil nil 0)
     (guile-line "^ *\\([0-9]+\\): *\\([0-9]+\\)" nil 1 2)
     )
   "Alist of values for `compilation-error-regexp-alist'.")





  reply	other threads:[~2015-09-16 21:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16  9:14 bug#21496: 25.0.50; guile-file compilation-error regexp is too wide Jostein Kjønigsen
2015-09-16 21:52 ` Stefan Monnier [this message]
2015-09-16 22:00   ` Jostein Kjønigsen
2015-09-20  7:44     ` Jostein Kjønigsen
2015-09-20  7:59       ` Andreas Schwab
2015-09-20  8:08         ` Jostein Kjønigsen
2015-09-20  9:10           ` Jostein Kjønigsen
2015-09-20 15:20       ` Stefan Monnier
2015-09-20 18:30         ` Jostein Kjønigsen
2015-09-20 19:49           ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtwquvya1.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=21496@debbugs.gnu.org \
    --cc=janneke@gnu.org \
    --cc=jostein@kjonigsen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.