* Re: [elpa] master 09380cc 1/2: packages/arbitools.el: minor fixes
[not found] ` <E1axeqR-0006FX-Nj@vcs.savannah.gnu.org>
@ 2016-05-03 19:04 ` Stefan Monnier
0 siblings, 0 replies; only message in thread
From: Stefan Monnier @ 2016-05-03 19:04 UTC (permalink / raw
To: emacs-devel; +Cc: David Gonzalez Gandara
> --- a/packages/arbitools/arbitools.el
> +++ b/packages/arbitools/arbitools.el
> @@ -273,6 +273,7 @@
> (interactive)
> (save-excursion
> (let ( (numberofrounds (arbitools-number-of-rounds))
> + (pointsstring "")
> (points 0.0)
> (pointstosum 0.0)
> (roundcount 1))
> @@ -283,7 +284,7 @@
> (while (<= roundcount numberofrounds)
> (beginning-of-line)
> (forward-char (+ 98 (* (- roundcount 1) 10))) ;; go to where the result is for each round
> - ;; FIXME: Use pcase?
> + (setq pointsstring (thing-at-point 'symbol))
> (cond ((string= (thing-at-point 'symbol) "1") (setq pointstosum 1.0))
> ((string= (thing-at-point 'symbol) "+") (setq pointstosum 1.0))
> ((string= (thing-at-point 'symbol) "=") (setq pointstosum 0.5))
Why?
The code never looks at this variable's value, AFAICT.
> @@ -309,7 +310,7 @@
> (let ((datachunk ""))
> (goto-char (point-min))
> (while (re-search-forward "^001" nil t)
> - (let* () ;; (linestring (thing-at-point 'line))
> + (let* ((linestring (thing-at-point 'line)))
> (beginning-of-line)
> (forward-char 89) ;; get the POS field
> (setq datachunk (thing-at-point 'word))
> @@ -410,6 +411,7 @@
> (save-excursion
> (while (re-search-forward "^013" nil t)
> (let* ((linestringteam (thing-at-point 'line))
> + (actualintegrant (string-to-number (substring linestringteam 40 44)))
> (integrantcount 0)
> (members 0))
Same for those two variables.
Stefan
^ permalink raw reply [flat|nested] only message in thread