From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 09380cc 1/2: packages/arbitools.el: minor fixes Date: Tue, 03 May 2016 15:04:14 -0400 Message-ID: References: <20160503181451.23959.70444@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462302306 18529 80.91.229.3 (3 May 2016 19:05:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 May 2016 19:05:06 +0000 (UTC) Cc: David Gonzalez Gandara To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 03 21:04:56 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1axfcu-0001Fs-4I for ged-emacs-devel@m.gmane.org; Tue, 03 May 2016 21:04:56 +0200 Original-Received: from localhost ([::1]:42980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axfcq-0005t3-BS for ged-emacs-devel@m.gmane.org; Tue, 03 May 2016 15:04:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axfcf-0005ar-P0 for emacs-devel@gnu.org; Tue, 03 May 2016 15:04:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axfcU-0006E1-2v for emacs-devel@gnu.org; Tue, 03 May 2016 15:04:36 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:53504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axfcT-00068E-S4 for emacs-devel@gnu.org; Tue, 03 May 2016 15:04:29 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u43J4Fqr021343; Tue, 3 May 2016 15:04:16 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 061EC60139; Tue, 3 May 2016 15:04:15 -0400 (EDT) In-Reply-To: (David Gonzalez Gandara's message of "Tue, 03 May 2016 18:14:51 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5661=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5661> : inlines <4753> : streams <1629460> : uri <2202514> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203553 Archived-At: > --- a/packages/arbitools/arbitools.el > +++ b/packages/arbitools/arbitools.el > @@ -273,6 +273,7 @@ > (interactive) > (save-excursion > (let ( (numberofrounds (arbitools-number-of-rounds)) > + (pointsstring "") > (points 0.0) > (pointstosum 0.0) > (roundcount 1)) > @@ -283,7 +284,7 @@ > (while (<= roundcount numberofrounds) > (beginning-of-line) > (forward-char (+ 98 (* (- roundcount 1) 10))) ;; go to where the result is for each round > - ;; FIXME: Use pcase? > + (setq pointsstring (thing-at-point 'symbol)) > (cond ((string= (thing-at-point 'symbol) "1") (setq pointstosum 1.0)) > ((string= (thing-at-point 'symbol) "+") (setq pointstosum 1.0)) > ((string= (thing-at-point 'symbol) "=") (setq pointstosum 0.5)) Why? The code never looks at this variable's value, AFAICT. > @@ -309,7 +310,7 @@ > (let ((datachunk "")) > (goto-char (point-min)) > (while (re-search-forward "^001" nil t) > - (let* () ;; (linestring (thing-at-point 'line)) > + (let* ((linestring (thing-at-point 'line))) > (beginning-of-line) > (forward-char 89) ;; get the POS field > (setq datachunk (thing-at-point 'word)) > @@ -410,6 +411,7 @@ > (save-excursion > (while (re-search-forward "^013" nil t) > (let* ((linestringteam (thing-at-point 'line)) > + (actualintegrant (string-to-number (substring linestringteam 40 44))) > (integrantcount 0) > (members 0)) Same for those two variables. Stefan