From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: David Gonzalez Gandara <dggandara@member.fsf.org>
Subject: Re: [elpa] master 09380cc 1/2: packages/arbitools.el: minor fixes
Date: Tue, 03 May 2016 15:04:14 -0400 [thread overview]
Message-ID: <jwvtwif9d74.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1axeqR-0006FX-Nj@vcs.savannah.gnu.org> (David Gonzalez Gandara's message of "Tue, 03 May 2016 18:14:51 +0000")
> --- a/packages/arbitools/arbitools.el
> +++ b/packages/arbitools/arbitools.el
> @@ -273,6 +273,7 @@
> (interactive)
> (save-excursion
> (let ( (numberofrounds (arbitools-number-of-rounds))
> + (pointsstring "")
> (points 0.0)
> (pointstosum 0.0)
> (roundcount 1))
> @@ -283,7 +284,7 @@
> (while (<= roundcount numberofrounds)
> (beginning-of-line)
> (forward-char (+ 98 (* (- roundcount 1) 10))) ;; go to where the result is for each round
> - ;; FIXME: Use pcase?
> + (setq pointsstring (thing-at-point 'symbol))
> (cond ((string= (thing-at-point 'symbol) "1") (setq pointstosum 1.0))
> ((string= (thing-at-point 'symbol) "+") (setq pointstosum 1.0))
> ((string= (thing-at-point 'symbol) "=") (setq pointstosum 0.5))
Why?
The code never looks at this variable's value, AFAICT.
> @@ -309,7 +310,7 @@
> (let ((datachunk ""))
> (goto-char (point-min))
> (while (re-search-forward "^001" nil t)
> - (let* () ;; (linestring (thing-at-point 'line))
> + (let* ((linestring (thing-at-point 'line)))
> (beginning-of-line)
> (forward-char 89) ;; get the POS field
> (setq datachunk (thing-at-point 'word))
> @@ -410,6 +411,7 @@
> (save-excursion
> (while (re-search-forward "^013" nil t)
> (let* ((linestringteam (thing-at-point 'line))
> + (actualintegrant (string-to-number (substring linestringteam 40 44)))
> (integrantcount 0)
> (members 0))
Same for those two variables.
Stefan
parent reply other threads:[~2016-05-03 19:04 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <E1axeqR-0006FX-Nj@vcs.savannah.gnu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtwif9d74.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dggandara@member.fsf.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.