From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Compilation warnings in mouse.el Date: Wed, 13 Jul 2016 11:12:35 -0400 Message-ID: References: <8360scdzik.fsf@gnu.org> <87zipnzvo4.fsf@gmx.net> <8337nfcupy.fsf@gnu.org> <83inw9a9tl.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468422795 25249 80.91.229.3 (13 Jul 2016 15:13:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Jul 2016 15:13:15 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 13 17:13:08 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bNLqV-0006LK-Lx for ged-emacs-devel@m.gmane.org; Wed, 13 Jul 2016 17:13:07 +0200 Original-Received: from localhost ([::1]:48325 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNLqU-0004rY-JT for ged-emacs-devel@m.gmane.org; Wed, 13 Jul 2016 11:13:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60005) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNLqI-0004f8-5a for emacs-devel@gnu.org; Wed, 13 Jul 2016 11:12:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNLqC-0005Pz-SU for emacs-devel@gnu.org; Wed, 13 Jul 2016 11:12:53 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:50203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNLqC-0005Po-LI for emacs-devel@gnu.org; Wed, 13 Jul 2016 11:12:48 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bNLq9-00067M-Bc for emacs-devel@gnu.org; Wed, 13 Jul 2016 17:12:45 +0200 Original-Received: from 69-165-156-121.dsl.teksavvy.com ([69.165.156.121]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jul 2016 17:12:45 +0200 Original-Received: from monnier by 69-165-156-121.dsl.teksavvy.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jul 2016 17:12:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 43 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 69-165-156-121.dsl.teksavvy.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:rHtFY//BIjkxI/9A7c0BNnr9pOs= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205640 Archived-At: >> The way I see it, defcustoms should pretty much never have :group, and >> the group to which they belong is simply determined by the file in which >> they occur. > But as long as such a system isn't installed, we shouldn't behave as > if it were. (And what you propose is not without downsides, I think.) Such a system has been installed ever since commit d3b80e9b70eaa0edb4cfc0d91543c41929fa70c0 Author: Stefan Monnier Date: Sun Nov 18 01:35:12 2001 +0000 (custom-current-group-alist): New var. (custom-declare-group): Set it. (custom-current-group): New fun. (custom-declare-variable, custom-handle-all-keywords): Use it as a default if no :group argument is specified. >> I don't see how removing/adding defcustoms in the same file >> would introduce problems. > We just saw such a problem, no? I must have missed something. All I saw was that someone added a defcustom in mouse.el and did not put a :group while there is no defgroup in that file (and all other defcustoms in there have a :group). That seems pretty far from "removing/adding defcustoms in the same file". >> PS: Incidentally, we have two definitions of the `mouse' group >> in cus-edit.el: > Thanks. Bonus points for fixing that. Hmm... Git didn't tell me how many points I got! BTW, I'm not really opposed to the use of :group in general. But I'm opposed to having it be mandatory in the obvious case of a single-file single-group package, where the :group args are just redundant. My above 2001 commit was designed to solve that case and it's proved to work fine since. Stefan