From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 ee04aed: Fix handling of buffer relocation in regex.c functions Date: Sun, 23 Oct 2016 16:31:24 -0400 Message-ID: References: <20161023191028.10942.12099@vcs.savannah.gnu.org> <20161023191028.C103F220124@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1477254738 12521 195.159.176.226 (23 Oct 2016 20:32:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Oct 2016 20:32:18 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 23 22:32:15 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byPR4-0001S0-Py for ged-emacs-devel@m.gmane.org; Sun, 23 Oct 2016 22:32:02 +0200 Original-Received: from localhost ([::1]:42342 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byPR7-0003U7-7m for ged-emacs-devel@m.gmane.org; Sun, 23 Oct 2016 16:32:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1byPQa-0003U1-71 for emacs-devel@gnu.org; Sun, 23 Oct 2016 16:31:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1byPQZ-00048B-KG for emacs-devel@gnu.org; Sun, 23 Oct 2016 16:31:32 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:14137) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1byPQV-00047r-UE; Sun, 23 Oct 2016 16:31:28 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BHAgALW9BX/1DcbkFdGwEBAQMBAQGDLQEBAQEBHoRNhVCEZasRggOGFgQCAoFpORQBAgEBAQEBAQFeJ4RiAQEEJy8WBgcQCzQSFBgNiQG8VQEBAQcCJYp9hQyFEAEEmVmRFQEVh2KGC4ZziVgeNoJoGxiBUSCGCgEBAQ X-IPAS-Result: A0BHAgALW9BX/1DcbkFdGwEBAQMBAQGDLQEBAQEBHoRNhVCEZasRggOGFgQCAoFpORQBAgEBAQEBAQFeJ4RiAQEEJy8WBgcQCzQSFBgNiQG8VQEBAQcCJYp9hQyFEAEEmVmRFQEVh2KGC4ZziVgeNoJoGxiBUSCGCgEBAQ X-IronPort-AV: E=Sophos;i="5.30,296,1470715200"; d="scan'208";a="276859423" Original-Received: from 65-110-220-80.cpe.pppoe.ca (HELO ceviche.home) ([65.110.220.80]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 23 Oct 2016 16:31:25 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id A958B661C9; Sun, 23 Oct 2016 16:31:24 -0400 (EDT) In-Reply-To: <20161023191028.C103F220124@vcs.savannah.gnu.org> (Eli Zaretskii's message of "Sun, 23 Oct 2016 19:10:28 +0000 (UTC)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208640 Archived-At: > + /* Update 'base' due to possible relocation inside re_search_2. */ > + base = current_buffer->text->beg; I recommend wrapping this in "#if REL_ALLOC", so as to make it clear why relation might be possible (e.g. to distinguish from GC-triggered relocation, for example) and to make it clear what could be gained by getting rid of REL_ALLOC. Stefan