all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Cc: Mark Oteiza <mvoteiza@udel.edu>
Subject: Re: [Emacs-diffs] master 1b4442b: Don't expand body inside a let-binding when there are no bindings
Date: Thu, 16 Feb 2017 08:32:06 -0500	[thread overview]
Message-ID: <jwvtw7umfqk.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20170216014308.12DC326007@vcs0.savannah.gnu.org> (Mark Oteiza's message of "Wed, 15 Feb 2017 20:43:07 -0500 (EST)")

> +  (if vars
> +      `(let ,(mapcar (lambda (b) (list (car b) (cdr b))) vars)
> +         ,@code)
> +    `(progn ,@code)))

Just curious here:

I resisted the temptation to do that when working on that code because
I thought that it should (both in the sense that I expect the current
code to behave that way, and in the sense that if it doesn't behave that
way, we should fix it) make no difference to the byte-code we generate.

So, I'm wondering if you've found a concrete case where it makes
a difference, or it's just that you wanted the output to look
more pretty.


        Stefan



       reply	other threads:[~2017-02-16 13:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170216014306.20854.5128@vcs0.savannah.gnu.org>
     [not found] ` <20170216014308.12DC326007@vcs0.savannah.gnu.org>
2017-02-16 13:32   ` Stefan Monnier [this message]
2017-02-17  4:44     ` [Emacs-diffs] master 1b4442b: Don't expand body inside a let-binding when there are no bindings Mark Oteiza
2017-02-18  0:05       ` Stefan Monnier
2017-02-18  0:10         ` Mark Oteiza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvtw7umfqk.fsf-monnier+emacsdiffs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=mvoteiza@udel.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.