From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/record 25aa500 5/5: Backward compatibility with pre-existing struct instances. Date: Tue, 28 Mar 2017 16:47:20 -0400 Message-ID: References: <20170328192614.13038.29393@vcs0.savannah.gnu.org> <20170328192617.32EF32017F@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1490734067 17182 195.159.176.226 (28 Mar 2017 20:47:47 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Mar 2017 20:47:47 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 28 22:47:44 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csy1Y-0002ZR-IB for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 22:47:28 +0200 Original-Received: from localhost ([::1]:55213 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csy1c-00039F-Ug for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 16:47:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csy1W-00038w-Pn for emacs-devel@gnu.org; Tue, 28 Mar 2017 16:47:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csy1S-0001Zd-H4 for emacs-devel@gnu.org; Tue, 28 Mar 2017 16:47:26 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:44758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csy1S-0001ZL-DF for emacs-devel@gnu.org; Tue, 28 Mar 2017 16:47:22 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id v2SKlKje017758; Tue, 28 Mar 2017 16:47:20 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 200A9601F5; Tue, 28 Mar 2017 16:47:20 -0400 (EDT) In-Reply-To: <20170328192617.32EF32017F@vcs0.savannah.gnu.org> (Lars Brinkhoff's message of "Tue, 28 Mar 2017 15:26:17 -0400 (EDT)") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5984=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5984> : inlines <5761> : streams <1738950> : uri <2399958> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213462 Archived-At: > --- a/lisp/emacs-lisp/cl-preloaded.el > +++ b/lisp/emacs-lisp/cl-preloaded.el > @@ -79,6 +79,8 @@ > (let ((tag (intern (format "cl-struct-%s" name))) > (type-and-named (get name 'cl-struct-type)) > (descs (get name 'cl-struct-slots))) > + (if (null (car type-and-named)) > + (setq type-and-named (cons 'record (cdr type-and-named)))) > (cl-struct-define name nil (get name 'cl-struct-include) > (unless (and (eq (car type-and-named) 'vector) > (null (cadr type-and-named)) Hmm... if we're in this code, it means we're in the case of an old-old struct (once compiled before we introduced cl-struct-define), so it's definitely not using `record`s. Stefan